review: comment contents

flutter · Dec 19, 2024 · c4e7b73 · c4e7b73
1 parent 4229674
commit c4e7b73
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm b/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm
@@ -1293,7 +1293,9 @@ - (NSString*)textInRange:(UITextRange*)range {
   if (textRange.location == NSNotFound) {
     // Avoids [crashes](https://github.com/flutter/flutter/issues/138464) from an assertion
     // against NSNotFound.
-    // TODO(hellohuanlin): root cause https://github.com/flutter/flutter/issues/160100
+    // TODO(hellohuanlin): This is a temp workaround, but we should look into why
+    // framework is providing NSNotFound to the engine.
+    // https://github.com/flutter/flutter/issues/160100
     return nil;
   }
   // Sanitize the range to prevent going out of bounds.

diff --git a/shell/platform/darwin/ios/framework/Source/TextInputSemanticsObject.mm b/shell/platform/darwin/ios/framework/Source/TextInputSemanticsObject.mm
@@ -45,7 +45,9 @@ - (NSString*)textInRange:(UITextRange*)range {
   if (textRange.location == NSNotFound) {
     // Avoids [crashes](https://github.com/flutter/flutter/issues/138464) from an assertion
     // against NSNotFound.
-    // TODO(hellohuanlin): https://github.com/flutter/flutter/issues/160100
+    // TODO(hellohuanlin): This is a temp workaround, but we should look into why
+    // framework is providing NSNotFound to the engine.
+    // https://github.com/flutter/flutter/issues/160100
     return nil;
   }
   return [self.text substringWithRange:textRange];