Skip to content

Commit

Permalink
[web] Make FLUTTER_WEB_AUTO_DETECT false by default
Browse files Browse the repository at this point in the history
  • Loading branch information
mdebbar committed Dec 12, 2024
1 parent 3cdd841 commit 732de15
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 11 deletions.
8 changes: 0 additions & 8 deletions lib/web_ui/dev/steps/compile_bundle_step.dart
Original file line number Diff line number Diff line change
Expand Up @@ -215,10 +215,6 @@ class Dart2JSCompiler extends TestCompiler {
'--disable-inlining',
'--enable-asserts',

// We do not want to auto-select a renderer in tests. As of today, tests
// are designed to run in one specific mode. So instead, we specify the
// renderer explicitly.
'-DFLUTTER_WEB_AUTO_DETECT=false',
'-DFLUTTER_WEB_USE_SKIA=${renderer == Renderer.canvaskit}',
'-DFLUTTER_WEB_USE_SKWASM=${renderer == Renderer.skwasm}',

Expand Down Expand Up @@ -280,10 +276,6 @@ class Dart2WasmCompiler extends TestCompiler {
'--enable-asserts',
'--enable-experimental-wasm-interop',

// We do not want to auto-select a renderer in tests. As of today, tests
// are designed to run in one specific mode. So instead, we specify the
// renderer explicitly.
'-DFLUTTER_WEB_AUTO_DETECT=false',
'-DFLUTTER_WEB_USE_SKIA=${renderer == Renderer.canvaskit}',
'-DFLUTTER_WEB_USE_SKWASM=${renderer == Renderer.skwasm}',

Expand Down
6 changes: 3 additions & 3 deletions lib/web_ui/lib/src/engine/configuration.dart
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,10 @@ class FlutterConfiguration {

/// Auto detect which rendering backend to use.
///
/// Using flutter tools option "--web-renderer=auto" or not specifying one
/// would set the value to true. Otherwise, it would be false.
/// Using flutter tools option "--web-renderer=auto" would set the value to
/// true. Otherwise, it would be false.
static const bool flutterWebAutoDetect =
bool.fromEnvironment('FLUTTER_WEB_AUTO_DETECT', defaultValue: true);
bool.fromEnvironment('FLUTTER_WEB_AUTO_DETECT');

static const bool flutterWebUseSkwasm =
bool.fromEnvironment('FLUTTER_WEB_USE_SKWASM');
Expand Down

0 comments on commit 732de15

Please sign in to comment.