Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the scheduler changes for monorepo in cocoon #4008

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jtmcdole
Copy link
Contributor

@jtmcdole jtmcdole commented Nov 4, 2024

Documentation for presubmits

@jtmcdole
Copy link
Contributor Author

jtmcdole commented Nov 5, 2024

For the "we get notified of check status" - we are already notified of completion from both LUCI and GitHub. To query the check status; there's already some code in the gitub utility file that could be reused; or we could use a document in firebase that has a TTL on it.

I'm leaning:

  1. Keep ci yaml validation open longer; it retains the "block submit"
  2. Make a new non-blocking "engine sentitle" for clarity; complete it with engine build status.
  3. Finish ci yaml once everything has been scheduled.

@yjbanov - We could remove the blocker on CI Task as well if we use CI yaml validation as the blocker. That leaves one blocker with multiple exists, but a good crumb trail.

Thoughts?

Co-authored-by: Christopher Fujino <[email protected]>
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jtmcdole and others added 2 commits November 5, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants