Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video_player_avplay] Resolve drm manager proxy doesn't support multiple instances issue. #660

Merged
merged 10 commits into from
Jan 30, 2024

Conversation

xiaowei-guan
Copy link
Contributor

@xiaowei-guan xiaowei-guan commented Jan 22, 2024

https://github.com/flutter-tizen/plugins/blob/master/packages/video_player_avplay/tizen/src/drm_manager_proxy.cc#L9-L14

FuncDMGRSetData DMGRSetData = nullptr;
FuncDMGRGetData DMGRGetData = nullptr;
FuncDMGRSetDRMLocalMode DMGRSetDRMLocalMode = nullptr;
FuncDMGRCreateDRMSession DMGRCreateDRMSession = nullptr;
FuncDMGRSecurityInitCompleteCB DMGRSecurityInitCompleteCB = nullptr;
FuncDMGRReleaseDRMSession DMGRReleaseDRMSession = nullptr;
  • If we create multiple Drm Manager, the new function pointer will overwrite the old ones, so we can extract a new class for drm manager proxy.
  • Do not need dclose drm manager handler right away, which can cause coredump issue.

@xiaowei-guan
Copy link
Contributor Author

Maybe we can change the drm manager proxy to a singleton.

@xiaowei-guan xiaowei-guan merged commit cf47694 into flutter-tizen:master Jan 30, 2024
6 checks passed
Copy link

@zg2nets zg2nets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants