[Clipboard] getData implementation added #65

pkosko · 2021-04-15T10:06:54Z

[Before] Clipboard.getData feature was not implemented

[After] Dart code below is able to gather system clipboard data:

      Future<ClipboardData?> d = Clipboard.getData(Clipboard.kTextPlain);
      void dataCallback(ClipboardData? d) {
        if (d != null) {
          String? text = d.text;
          if(text != null) {
            print("Clipboard data $text");
          }
        }
      }
      d.then(dataCallback);

[TODO] Need to consider adding some mechanism of synchronization of access to native cbhm API
to provide proper behaviour in case of multiple calls

Change related to PlatformChannel Clipboard.getData() part of https://github.sec.samsung.net/f-project/home/issues/35
https://github.sec.samsung.net/f-project/home/issues/35

Necessary dependency was added to tizen_tools with PR flutter-tizen/tizen_tools#8

Necessary for flutter-tizen/engine#65

rwalczyna · 2021-04-15T10:54:41Z

shell/platform/tizen/channels/platform_channel.cc

+    const rapidjson::Value& format = call.arguments()[0];
+
+    // https://api.flutter.dev/flutter/services/Clipboard/kTextPlain-constant.html
+    // API supports only kTextPlain format, hovewer cbhm API supports also other formats


Suggested change

// API supports only kTextPlain format, hovewer cbhm API supports also other formats

// API supports only kTextPlain format, however cbhm API supports also other formats

rwalczyna · 2021-04-15T10:59:53Z

shell/platform/tizen/channels/platform_channel.cc

+
+    ret = cbhm_selection_get(cbhm_handle, selection_type, cbhm_selection_data_cb, data);
+    if (CBHM_ERROR_NONE != ret) {
+      result->Error(kUnknownClipboardError, "Failed to gather data.");


Shouldn't we free data in case of failure?

Also result is invalidated in line 89.

Good point, I will fix it!

swift-kim · 2021-04-15T11:05:58Z

Sorry. I was not aware of the tizen_tools PR!

[Before] Clipboard.getData feature was not implemented [After] Dart code below is able to gather system clipboard data: Future<ClipboardData?> d = Clipboard.getData(Clipboard.kTextPlain); void dataCallback(ClipboardData? d) { if (d != null) { String? text = d.text; if(text != null) { print("Clipboard data $text"); } } } d.then(dataCallback); [TODO] Need to consider adding some mechanism of synchronization of access to native cbhm API to provide proper behaviour in case of multiple calls

pwasowski2 · 2021-04-15T16:09:02Z

shell/platform/tizen/channels/platform_channel.cc

+    int ret = cbhm_open_service (&cbhm_handle);
+    if (CBHM_ERROR_NONE != ret) {
+      result->Error(kUnknownClipboardError, "Failed to initialize cbhm service.");
+      return;


Shouldn't is_processing be set to false before return?

pwasowski2 · 2021-04-15T16:10:48Z

shell/platform/tizen/channels/platform_channel.cc

@@ -37,7 +49,99 @@ void PlatformChannel::HandleMethodCall(
  } else if (method == "HapticFeedback.vibrate") {
    result->NotImplemented();
  } else if (method == "Clipboard.getData") {
-    result->NotImplemented();
+    const rapidjson::Value& format = call.arguments()[0];


Consider moving the body of this "if" to a separate method to make PlatformChannel::HandleMethodCall shorter.

pwasowski2 · 2021-04-15T16:13:11Z

shell/platform/tizen/channels/platform_channel.cc

+      return;
+    }
+
+    struct method_data_t {


Shouldn't we use Google coding style here and name this MethodData?

swift-kim · 2021-04-16T04:17:07Z

Tip: If you're using VS Code you can easily format your code by applying the following.

Enable "Format on Save" in the settings
Install the "C/C++" extension
Add "C_Cpp.clang_format_fallbackStyle": "Google" to the workspace settings

Caution: Make sure a correct clang-format executable is being used by VS Code. To verify, run

$ which clang-format

in the command line and check the location of the executable. (depot_tools should not appear in the path.)

The extension documentation says:

The full path of the clang-format executable. If not specified, and clang-format is available in the environment path, that is used. If not found in the environment path, a copy of clang-format bundled with the extension will be used.

To specify the clang-format executable path for VS Code, first install clang-format-11 (sudo apt install clang-format-11) and add this line to the workspace settings:

"C_Cpp.clang_format_path": "/usr/bin/clang-format-11"

swift-kim · 2021-04-16T04:27:54Z

Thank you for your contribution!

As far as I can see the CBHM API is mobile-only, so probably the embedder with this change will not even load on non-mobile devices (e.g. watch) because libcbhm will not exist on those devices. I'm currently thinking about how to release different embedders for different profiles (mobile/wearable/tv/iot) and integrate with the flutter-tizen tool. The design is not fixed yet but it will use compiler switches like #ifdef TV_PROFILE. You will have to wait a while until it is implemented for your change to be merged. Otherwise you can suggest any other ways to deal with the problem!

Necessary for flutter-tizen/engine#65

swift-kim · 2021-04-27T05:17:14Z

Now #67 has been merged and you can guard any code that is for mobile only using #ifdef MOBILE_PROFILE or #if defined(MOBILE_PROFILE). Also you will have to change BUILD.gn as follows:

diff --git a/shell/platform/tizen/BUILD.gn b/shell/platform/tizen/BUILD.gn
index 1ea9bcf30..bb9837748 100644
--- a/shell/platform/tizen/BUILD.gn
+++ b/shell/platform/tizen/BUILD.gn
@@ -38,6 +38,7 @@ config("tizen_rootstrap_include_dirs") {
     "$custom_sysroot/usr/include",
     "$custom_sysroot/usr/include/appfw",
     "$custom_sysroot/usr/include/base",
+    "$custom_sysroot/usr/include/cbhm",
     "$custom_sysroot/usr/include/dlog",
     "$custom_sysroot/usr/include/ecore-1",
     "$custom_sysroot/usr/include/ecore-evas-1",
@@ -141,6 +142,10 @@ template("embedder_for_profile") {
       libs += [ "ecore_wl2" ]
     }

+    if (target_name == "mobile") {
+      libs += [ "cbhm" ]
+    }
+
     cflags_cc = [
       "-Wno-newline-eof",
       "-Wno-macro-redefined",

pkosko · 2021-04-27T11:55:36Z

Unfortunately, implementation using public CBHM API has issue which disqualifies it as stable copy/paste support even on mobile only. In case of Flutter application using simple TextField in its UI:

TextField(
              decoration: InputDecoration(
                border: OutlineInputBorder(),
                hintText: 'Enter a search term',
              ),
            ),

, framework automatically calls Clipboard.getData() method during first run of application. According to my analysis and testing, in such case native API (cbhm_selection_get) does not trigger success callback (cbhm_selection_data_cb), nor return any error. Because current implementation is based on mutexes to protect accessing from different threads, this scenario causes a deadlock-like API state which always return error "Already processing in other thread" (because is_processing flag was not released in callback). I've tried to workaround this problem, but my all ideas were very ugly hacks which also does not guarantee memory safety and proper API behaviours in all cases.

Because of above issue of native API, I think that it is better to not include this PR to final code.

pkosko · 2021-04-27T11:57:29Z

I've prepared much simpler implementation #76 which uses naive in-application clipboard. Please share your opinion.

…rt API. Minor refactor of tessellator to supply fill type to method rather than to object. (#65)

pkosko requested review from a team and removed request for a team April 15, 2021 10:09

pkosko added a commit to pkosko/tizen_tools that referenced this pull request Apr 15, 2021

[Dependency] Added dependency build for CBHM API

9be6cd6

Necessary for flutter-tizen/engine#65

pkosko requested a review from a team April 15, 2021 10:16

rwalczyna suggested changes Apr 15, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

pkosko force-pushed the clipboard_getData branch from 6079c1c to 0435387 Compare April 15, 2021 12:24

pwasowski2 reviewed Apr 15, 2021

View reviewed changes

swift-kim mentioned this pull request Apr 16, 2021

Embedders for each device profile flutter-tizen/flutter-tizen#86

Closed

4 tasks

pkosko added a commit to pkosko/tizen_tools that referenced this pull request Apr 19, 2021

[Dependency] Added dependency build for CBHM API

73a9b38

Necessary for flutter-tizen/engine#65

pkosko added a commit to pkosko/tizen_tools that referenced this pull request Apr 19, 2021

[Dependency] Added dependency build for CBHM API

256b365

Necessary for flutter-tizen/engine#65

swift-kim mentioned this pull request Apr 27, 2021

[HapticFeedback] Implement vibrate() #75

Merged

pkosko closed this Apr 27, 2021

pkosko mentioned this pull request Apr 28, 2021

[Clipboard] setData and getData implementations added #76

Merged

pwasowski2 mentioned this pull request Apr 28, 2021

Separate builds for profiles #67

Merged

swift-kim mentioned this pull request May 11, 2021

Add support for service tizen application flutter-tizen/flutter-tizen#96

Merged

swift-kim mentioned this pull request Jun 26, 2021

Some unresolved issues #53

Closed

12 tasks

swift-kim pushed a commit that referenced this pull request Sep 1, 2022

[tessellator]Expose and document smoothing approximation via the C/Da…

e5fc548

…rt API. Minor refactor of tessellator to supply fill type to method rather than to object. (#65)

swift-kim mentioned this pull request Dec 12, 2022

Improve the clipboard implementation flutter-tizen/embedder#12

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Clipboard] getData implementation added #65

[Clipboard] getData implementation added #65

pkosko commented Apr 15, 2021 •

edited

Loading

rwalczyna Apr 15, 2021

rwalczyna Apr 15, 2021

rwalczyna Apr 15, 2021

pkosko Apr 15, 2021

This comment has been minimized.

swift-kim commented Apr 15, 2021

pwasowski2 Apr 15, 2021

pwasowski2 Apr 15, 2021

pwasowski2 Apr 15, 2021

swift-kim commented Apr 16, 2021 •

edited

Loading

swift-kim commented Apr 16, 2021

swift-kim commented Apr 27, 2021

pkosko commented Apr 27, 2021

pkosko commented Apr 27, 2021

	// API supports only kTextPlain format, hovewer cbhm API supports also other formats
	// API supports only kTextPlain format, however cbhm API supports also other formats

[Clipboard] getData implementation added #65

[Clipboard] getData implementation added #65

Conversation

pkosko commented Apr 15, 2021 • edited Loading

rwalczyna Apr 15, 2021

Choose a reason for hiding this comment

rwalczyna Apr 15, 2021

Choose a reason for hiding this comment

rwalczyna Apr 15, 2021

Choose a reason for hiding this comment

pkosko Apr 15, 2021

Choose a reason for hiding this comment

This comment has been minimized.

swift-kim commented Apr 15, 2021

pwasowski2 Apr 15, 2021

Choose a reason for hiding this comment

pwasowski2 Apr 15, 2021

Choose a reason for hiding this comment

pwasowski2 Apr 15, 2021

Choose a reason for hiding this comment

swift-kim commented Apr 16, 2021 • edited Loading

swift-kim commented Apr 16, 2021

swift-kim commented Apr 27, 2021

pkosko commented Apr 27, 2021

pkosko commented Apr 27, 2021

pkosko commented Apr 15, 2021 •

edited

Loading

swift-kim commented Apr 16, 2021 •

edited

Loading