Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Add macos arm64 build and release #372

Merged

Conversation

JSUYA
Copy link
Member

@JSUYA JSUYA commented Jan 15, 2025

Apple silicon is arm64 architecture. Therefore, add engine release distribution for arm64.

@swift-kim
Copy link
Member

Will we drop the Rosetta dependency? The original flutter_tools still has the requirement.

@JSUYA
Copy link
Member Author

JSUYA commented Jan 15, 2025

Will we drop the Rosetta dependency? The original flutter_tools still has the requirement.

The getCurrentHostPlatform() has been changed to return 'darwin-arm64' on Apple Silicon.
flutter/flutter#154645
I have been thinking about two ways.

  1. Modify getArtifactPath() of flutter-tizen/lib/tizen_artifacts.dart to always refer to darwin-x64.
  2. Install gen_snapshot built on apple silicon as darwin-arm64 along with darwin-x64.(modify getBinaryDirs() of flutter-tizen/lib/tizen_cache.dart.)

I didn't consider about Rosseta dependency.

@swift-kim
Copy link
Member

@JSUYA Okay, this approach looks good :)

@JSUYA JSUYA merged commit 4d673e9 into flutter-tizen:flutter-3.27.1 Jan 16, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants