Fix FlutterEngineOnVsync being called after engine shutdown (#355)

flutter-tizen · Sep 27, 2022 · f11f8f1 · f11f8f1
1 parent e72a4b2
commit f11f8f1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/shell/platform/tizen/tizen_vsync_waiter.cc b/shell/platform/tizen/tizen_vsync_waiter.cc
@@ -32,7 +32,7 @@ TizenVsyncWaiter::TizenVsyncWaiter(FlutterTizenEngine* engine) {
 }
 
 TizenVsyncWaiter::~TizenVsyncWaiter() {
-  tdm_client_.reset();
+  tdm_client_->OnEngineStop();
 
   SendMessage(kMessageQuit, 0);
 
@@ -130,10 +130,6 @@ TdmClient::TdmClient(FlutterTizenEngine* engine) {
 }
 
 TdmClient::~TdmClient() {
-  {
-    std::lock_guard<std::mutex> lock(engine_mutex_);
-    engine_ = nullptr;
-  }
   if (vblank_) {
     tdm_client_vblank_destroy(vblank_);
     vblank_ = nullptr;
@@ -145,6 +141,15 @@ TdmClient::~TdmClient() {
   }
 }
 
+bool TdmClient::IsValid() {
+  return vblank_ && client_;
+}
+
+void TdmClient::OnEngineStop() {
+  std::lock_guard<std::mutex> lock(engine_mutex_);
+  engine_ = nullptr;
+}
+
 void TdmClient::AwaitVblank(intptr_t baton) {
   baton_ = baton;
   tdm_error ret = tdm_client_vblank_wait(vblank_, 1, VblankCallback, this);
@@ -155,10 +160,6 @@ void TdmClient::AwaitVblank(intptr_t baton) {
   tdm_client_handle_events(client_);
 }
 
-bool TdmClient::IsValid() {
-  return vblank_ && client_;
-}
-
 void TdmClient::VblankCallback(tdm_client_vblank* vblank,
                                tdm_error error,
                                unsigned int sequence,

diff --git a/shell/platform/tizen/tizen_vsync_waiter.h b/shell/platform/tizen/tizen_vsync_waiter.h
@@ -23,6 +23,7 @@ class TdmClient {
   virtual ~TdmClient();
 
   bool IsValid();
+  void OnEngineStop();
   void AwaitVblank(intptr_t baton);
 
  private: