support query-string t val in from, from-named #56
+46
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonotope
approved these changes
Apr 29, 2024
| (is (= {"ledger" ledger-name, "t" 2} | ||
| (-> res :body json/read-value (select-keys ["ledger" "t"]))))))) | ||
|
|
||
| (deftest ^:integration ^:json transaction-with-dbs-at-multiple-t-values |
Contributor
There was a problem hiding this comment.
I think this test could use more English commentary through more nested testing macros and/or using the third, msg argument of the is macro.
Contributor
|
Are these changes still relevant in light of fluree/db#1088? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates the new query-string t value syntax in fluree/db as per this PR:
fluree/db#761
The functionality is exposed through the
/queryAPI allowing queryfromandfrom-namedkeys to specify t values as per the following example:Adds a test