Backport(v1.16): test: ensure removing old engine on setup (#5057) #5085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to merge the following PR first. |
daipom
force-pushed
the
barkport-pr5057
branch
2 times, most recently
from
619bcee to
40c5791
Compare
**Which issue(s) this PR fixes**: Continued from * fluent#5054 * fluent#5055 (6cac9f0) **What this PR does / why we need it**: Each test should not consider the initialization of `Fluent::Engine`. It should be the responsibility of `Fluent::Test.setup`. Note: Set `nil` explicitly to ensure that GC can remove the objects, though it is very strange that some objects can still exist after `remove_const` and `GC.start`. **Docs Changes**: Not needed. **Release Note**: CI improvements. Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
force-pushed
the
barkport-pr5057
branch
from
40c5791 to
5935ca0
Compare
Watson1978
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Continued from
What this PR does / why we need it:
Each test should not consider the initialization of
Fluent::Engine. It should be the responsibility ofFluent::Test.setup.Note: Set
nilexplicitly to ensure that GC can remove the objects, though it is very strange that some objects can still exist afterremove_constandGC.start.Docs Changes:
Not needed.
Release Note:
CI improvements.