Skip to content

Conversation

Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Sep 2, 2025

This PR create blog achive page.
image

The archive page will be linked from bottom of blog page.

image

Signed-off-by: Shizuo Fujita <[email protected]>
@kenhys
Copy link
Contributor

kenhys commented Sep 2, 2025

How about adding navigation under "Recent Posts" sidebar, too?

@Watson1978
Copy link
Contributor Author

How about adding navigation under "Recent Posts" sidebar, too?

Thanks. Added 👍🏻

Signed-off-by: Shizuo Fujita <[email protected]>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this improvement!
This is the feature I've always wanted!

However, from the perspective of consistency and maintainability, wouldn't it be better not to use page-specific styles?
For example, wouldn't the following common style be sufficient?

Screenshot from 2025-09-02 17-45-30

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d like to hear your opinions, @Watson1978 and @kenhys.

If we were to implement it using only Bootstrap 3 features, it would probably look something like this..
However, from a design perspective, the current code seems better.

What concerns me is that none of the other views use page-specific styles.
Should we avoid using page-specific styles, or go ahead and use them?

Screenshot from 2025-09-02 19-46-40

Comment on lines 1 to 5
<style>
.pager{margin-top:20px;display:flex;gap:12px;align-items:center}
.pager .page{opacity:.7}
</style>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<style>
.pager{margin-top:20px;display:flex;gap:12px;align-items:center}
.pager .page{opacity:.7}
</style>

Comment on lines 23 to 31
<nav class="pager">
<% if page > 1 %>
<a class="prev" href="?page=<%= page - 1 %>">&laquo; Newer</a>
<% end %>
<span class="page">Page <%= page %> / <%= total_pages %></span>
<% if page < total_pages %>
<a class="next" href="?page=<%= page + 1 %>">Older &raquo;</a>
<% end %>
</nav>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<nav class="pager">
<% if page > 1 %>
<a class="prev" href="?page=<%= page - 1 %>">&laquo; Newer</a>
<% end %>
<span class="page">Page <%= page %> / <%= total_pages %></span>
<% if page < total_pages %>
<a class="next" href="?page=<%= page + 1 %>">Older &raquo;</a>
<% end %>
</nav>
<nav class="pull-left">
<ul class="pager">
<% if page > 1 %>
<li><a href="?page=<%= page - 1 %>">&laquo; Newer</a></li>
<% end %>
<li>Page <%= page %> / <%= total_pages %></li>
<% if page < total_pages %>
<li><a href="?page=<%= page + 1 %>">Older &raquo;</a></li>
<% end %>
</ul>
</nav>

@Watson1978
Copy link
Contributor Author

We discussed and decided to separate the pagination feature.

Signed-off-by: Shizuo Fujita <[email protected]>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this improvement!

@daipom daipom merged commit 8ac34bc into fluent:master Sep 3, 2025
2 checks passed
@Watson1978 Watson1978 deleted the blog-archive branch September 3, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants