workflows: add librdkafka to the system libs workflow #10803
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubuntu:22.04: Setting up librdkafka-dev:amd64 (1.8.0-1build1) ... ubuntu:24.04: Setting up librdkafka-dev:amd64 (2.3.0-1build2) ... So we can only enforce it for ubuntu:24.04. Signed-off-by: Thomas Devoogdt <[email protected]>
ThomasDevoogdt
requested review from
niedbalski,
patrick-stephens and
celalettin1286
as code owners
WalkthroughThe PR updates the PR compile check workflow to install librdkafka-dev and extends ldd-based dependency verification to include librdkafka alongside libmsgpack, adjusting step names and greps accordingly within the Ubuntu 24.04 job. Changes
Sequence Diagram(s)sequenceDiagram
actor Dev as Developer
participant GH as GitHub Actions
participant R as Runner (ubuntu-24.04)
Dev->>GH: Open PR
GH->>R: Start pr-compile-check workflow
R->>R: Checkout code
rect rgb(240,248,255)
note over R: System libraries installation (updated)
R->>R: apt-get install ... librdkafka-dev
end
R->>R: Build project/binaries
rect rgb(245,255,245)
note over R: Dependency verification (expanded)
R->>R: ldd <binary> | grep libmsgpack
R->>R: ldd <binary> | grep librdkafka
R->>R: Display ldd results (includes librdkafka)
end
R-->>GH: Report job status
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/pr-compile-check.yaml (2)
71-71: Good addition; consider logging exact package versions for traceabilityInstalling librdkafka-dev here is correct. To aid debugging across Ubuntu 22.04 vs 24.04, print the installed versions of librdkafka-dev and libmsgpack-dev right after apt install.
sudo apt-get install -y libc-ares-dev libjemalloc-dev libluajit-5.1-dev \ - libnghttp2-dev libsqlite3-dev libzstd-dev libmsgpack-dev librdkafka-dev + libnghttp2-dev libsqlite3-dev libzstd-dev libmsgpack-dev librdkafka-dev + echo "Installed versions:" + dpkg -l | awk '/libmsgpack-dev|librdkafka-dev/ {print $1, $2, $3}' + apt-cache policy librdkafka-dev | sed -n 's/ Installed: /librdkafka-dev Installed: /p' + apt-cache policy libmsgpack-dev | sed -n 's/ Installed: /libmsgpack-dev Installed: /p'
115-122: Tighten ldd checks to match actual sonames and fail fastOn Debian/Ubuntu the runtime sonames are libmsgpackc.so.X and librdkafka.so.X. Grepping “libmsgpack” can produce false positives. Also add strict shell options.
- - name: Display dependencies w/ ldd for libmsgpack and librdkafka + - name: Display dependencies w/ ldd for libmsgpack and librdkafka if: matrix.os.version == 'ubuntu-24.04' run: | - export ldd_result=$(ldd ./bin/fluent-bit) - echo "ldd result:" - echo "$ldd_result" | grep libmsgpack - echo "$ldd_result" | grep librdkafka + set -Eeuo pipefail + ldd_result="$(ldd ./bin/fluent-bit)" + echo "$ldd_result" + echo "$ldd_result" | grep -E 'libmsgpackc\.so(\.[0-9]+)?' + echo "$ldd_result" | grep -E 'librdkafka\.so(\.[0-9]+)?' working-directory: build
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/pr-compile-check.yaml(2 hunks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubuntu:22.04:
Setting up librdkafka-dev:amd64 (1.8.0-1build1) ...
ubuntu:24.04:
Setting up librdkafka-dev:amd64 (2.3.0-1build2) ...
So we can only enforce it for ubuntu:24.04.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit