Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flow version to latest #413

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

Brianzchen
Copy link

@Brianzchen Brianzchen commented Mar 13, 2021

Update flow from 0.107.0 to 0.146.0 to establish a good base to continue further development on the project.

Also disable linting rules in particular areas so that yarn eslint . doesn't throw errors and we have a cleaner project

The major goal here is to clean up all flow errors without changing the underlying logic as I cannot be sure what the overall impact would be and also there are minimal tests in general

Closes #410

@Brianzchen Brianzchen changed the title Update flow version to latest [WIP] Update flow version to latest Mar 13, 2021
@Brianzchen Brianzchen changed the title Update flow version to latest Update flow version to latest [WIP] Mar 13, 2021
@Brianzchen Brianzchen changed the title Update flow version to latest [WIP] Update flow version to latest Mar 13, 2021
@Brianzchen
Copy link
Author

Ran compiler and tested on local vscode

@noppa noppa mentioned this pull request Apr 7, 2021
@mroch
Copy link
Contributor

mroch commented Jul 26, 2022

thanks for this! I had to push through an update to 0.183.0 in 8e38e1e, but this PR has a lot of better fixes so I'd like to leave this open and rebase it when I get some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants