-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flow version to latest #413
Open
Brianzchen
wants to merge
9
commits into
flow:main
Choose a base branch
from
Brianzchen:update-flow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brianzchen
changed the title
Update flow version to latest [WIP]
Update flow version to latest
Mar 13, 2021
Brianzchen
changed the title
Update flow version to latest
Update flow version to latest [WIP]
Mar 13, 2021
Brianzchen
changed the title
Update flow version to latest [WIP]
Update flow version to latest
Mar 13, 2021
Ran compiler and tested on local vscode |
Closed
thanks for this! I had to push through an update to 0.183.0 in 8e38e1e, but this PR has a lot of better fixes so I'd like to leave this open and rebase it when I get some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update flow from 0.107.0 to 0.146.0 to establish a good base to continue further development on the project.
Also disable linting rules in particular areas so that
yarn eslint .
doesn't throw errors and we have a cleaner projectThe major goal here is to clean up all flow errors without changing the underlying logic as I cannot be sure what the overall impact would be and also there are minimal tests in general
Closes #410