Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge yet] add energy model classes to master #992

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

liljonnystyle
Copy link
Collaborator

@liljonnystyle liljonnystyle commented Jul 7, 2020

Pull request information

  • Status: in development
  • Kind of changes: new feature

Description

Provide architecture for calculating energy consumption for reward functions. Implemented energy models are based on physics arguments.

Still to do:

  • Fix PDMElectric after getting updated calculation from Rabie
  • Implement unit tests

@kjang96
Copy link
Member

kjang96 commented Jul 8, 2020

Linking with pull #944. LGTM after the build passes

@liljonnystyle
Copy link
Collaborator Author

Linking with pull #995

@liljonnystyle liljonnystyle changed the title add energy model classes to master [do not merge yet] add energy model classes to master Jul 8, 2020
@17150934
Copy link

Can the vehicle class-passenger modify as electric vehicle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants