I210 dev fix #890
Open
I210 dev fix #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenevinitsky
requested review from
AboudyKreidieh,
cathywu and
kanaadp
as code owners
eugenevinitsky
force-pushed
the
i210_dev_fix
branch
from
67d4f01
to
942fe56
Compare
kanaadp
approved these changes
Mar 29, 2020
| @@ -110,9 +133,11 @@ def run_model_stablebaseline(flow_params, | |||
| def setup_exps_rllib(flow_params, | |||
| n_cpus, | |||
| n_rollouts, | |||
| flags, | |||
There was a problem hiding this comment.
will this break replay scripts? are there any other handles to setup_exps_rllib?
| ), | ||
|
|
||
| # environment related parameters (see flow.core.params.EnvParams) | ||
| env=EnvParams( | ||
| horizon=HORIZON, | ||
| sims_per_step=1, | ||
| warmup_steps=0, |
There was a problem hiding this comment.
is this correct? do we want warm up steps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request information
Description
? (general description)