Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update m_language_builtins to use the latest MATLAB release #240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

PeterTillema
Copy link

@PeterTillema PeterTillema commented Nov 8, 2021

Also, besides this, it would be nice if Windows is supported as well, where MATLAB is named matlab.exe, not matlab :)

@florianschanda
Copy link
Owner

Also, besides this, it would be nice if Windows is supported as well, where MATLAB is named matlab.exe, not matlab :)

Development environment for MH will stay Linux, it's just not worth it to deal with Windows issues. Unless I get a sudden influx of windows contributors :) But of course the tool itself always will support any platform that Python runs on!

First, thank you for this PR.

Before I apply this I want to quickly have a think about language support in general. Right now my real life work uses this tool and they are on a certain MATLAB version; so uplifting this would mean I need to fork.

But what I really want actually is to have a language option beyond "octave = true/false"; and this PR is a good reminder that I should do that sooner rather than later.

I've been a bit busy and non-responsive and for that I apologise, but again thank you for the PR; I will do something about it possibly on the weekend.

@krishnakumarg1984
Copy link

Mini bump

@florianschanda
Copy link
Owner

@krishnakumarg1984 and @PeterTillema I have not forgotten about this. I got another ticket now with a similar root issue (#258) and I will now say that this is the next big thing to be happening for MH (the detailed config of language dialect).

@florianschanda
Copy link
Owner

OK, so this is coming to the next release. I will push a massive change soon that allows you to say matlab: 2017b or octave: 4.4 in your config file.

While it doesn't do immediately what is asked for in this PR; it enables it.

florianschanda added a commit that referenced this pull request Aug 21, 2022
Previously there was a very rough switch --octave. Now there is
a very fine-grained control of the language dialect; but this brings
with it some minor backwards incompatibilities.

In particular:
* the --octave parameter now has a mandatory argument, if you want to
  get to the old behaviour use --octave=latest
* the octave config file entry still works when using "octave: true"
  (but you get a deprecation warning soon). The entry "octave: false"
  is now an error

This should also enable finally fixing #240.

Closes #86
Closes #258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants