Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Florian => Fix the example app, fixes #17 #39 #33 #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orta
Copy link
Collaborator

@orta orta commented Apr 17, 2016

I'll save this one for a patch release, and get 1.0.0 out - so this isn't blocking.

I'm interested in the ramifications here:

-    CGFloat multiplier = 0;
+    CGFloat multiplier = 0.01;

It seems reasonable to think when FLKAutoLayout was written Auto Layout would accept a multiplier of 0 in constraints - but since then, maybe since iOS8? The API does not allow using a 0 as the multiplier - which causes crashes in the example app, and assumably in all of the app code ( I don't see any uses of distributeCenterXOfViews or the others in Eigen, I expect because of this. )

Can you think of a better way to do this, and/or do you think this would cause issues?

/cc @alloy if you want to have a think too

@alloy
Copy link
Contributor

alloy commented Apr 19, 2016

You should probably use a -[NSLayoutConstraint constant] of 0 for that case, so that the end result is still really 0.

@orta
Copy link
Collaborator Author

orta commented Apr 19, 2016

Ah yes, this makes sense.

@orta
Copy link
Collaborator Author

orta commented May 18, 2016

Hrm, I thought I understood this, but it seems I don't - @alloy any chance you can take a look at fixing this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants