Remove support for EOL Ruby 2.6/2.7, Rails 5.2/6.0 #776
+19
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a big fan of cleanups and simplifications! Ruby 2.6 and Rails 5 can definitely go. I'm more on the fence about Ruby 2.7 can we add the constraint to the gemspec ( |
Yes, good suggestion. I think I'll let this sit for now because we do still have some Flipper Cloud customers using Ruby 2.7. I added framework stats in #780 so we can see if anyone is using old Rails versions, and that will go out in 1.1 hopefully this week. |
* origin/main: Rescue framework detection to ensure it never breaks Fix telemetry error by using webmock headers matcher Include client framework versions in API requests Remove duplicate entry from changelog statsd cleanup
* origin/main: (77 commits) Use Gem::Specification.load to load other gemspecs Add Ruby 3.3 to the build matrix Fix for setting strict = true Env var for sending debug output to stdout Add more frameworks and standardize header keys Run http specs when client changes Minor reformatting Another lowercase header Standardize on lower case hyphen headers Accept encoding gzip for cloud Symbol header Add proof it works with gzip Allow api to deflate responses when requested use rack constants Fix: Define default_strict_value before it's called Use flippercloud.io API, don't retry failures Move rails constants Show deprecation warning for Rails < 6.1.0 Show deprecation warning for Ruby < 3.0 UI: show a badge if a new release is available ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose we drop support for EOL Ruby and Rails versions.
Any reservations about doing this now before the upcoming 1.1 release?We will wait until the 2.0 release.EOL dates:
Ruby 2.6 - 31 Mar 2022 - 20 months ago
Rails 5.2 - 01 Jun 2022 - 18 months ago
Ruby 2.7 - 31 Mar 2023 - 8 months ago
Rails 6.0 - 01 Jun 2023 - 6 months ago