feat(core): support nested .gitignore files in filtering #2156

kovsu · 2026-01-27T08:34:48Z

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked as status: accepting prs
Steps in CONTRIBUTING.md were taken

Overview

changeset-bot · 2026-01-27T08:34:52Z

🦋 Changeset detected

Latest commit: 571dc60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages

Name	Type
@flint.fyi/core	Patch
@flint.fyi/astro	Patch
@flint.fyi/browser	Patch
@flint.fyi/cli	Patch
@flint.fyi/json-language	Patch
@flint.fyi/json	Patch
@flint.fyi/jsx	Patch
@flint.fyi/markdown-language	Patch
@flint.fyi/md	Patch
@flint.fyi/next	Patch
@flint.fyi/node	Patch
@flint.fyi/nuxt	Patch
@flint.fyi/package-json	Patch
@flint.fyi/performance	Patch
@flint.fyi/plugin-flint	Patch
@flint.fyi/react	Patch
@flint.fyi/rule-tester	Patch
@flint.fyi/solid	Patch
@flint.fyi/spelling	Patch
@flint.fyi/text-language	Patch
@flint.fyi/ts	Patch
@flint.fyi/typescript-language	Patch
@flint.fyi/yaml-language	Patch
@flint.fyi/yaml	Patch
@flint.fyi/site	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-01-27T08:34:53Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
flint	Ready	Preview, Comment	Jan 31, 2026 5:58am

JoshuaKGoldberg · 2026-01-27T18:01:26Z

packages/core/src/running/createGitignoreFilter.ts

[Question] This is a lot of added logic. Back in #1856 (comment) I'd found a couple of other packages: gitignore-to-glob, globify-gitignore. Regardless of what package we use, I think it would be nice to have to manage this logic ourselves. Did you try out those packages and/or others? Is there some reason they aren't workable?

I'd found a couple of other packages: gitignore-to-glob, globify-gitignore.

Both of them are no longer maintained. The logic also isn’t particularly complex — for example, gitignore-to-glob is only around 80 lines of code.

Regardless of what package we use, I think it would be nice to have to manage this logic ourselves.

100 percent agree.

Did you try out those packages and/or others? Is there some reason they aren't

I didn't try them

globify-gitignore doesn't have any open issues or PRs, so I think it might just be "done" (working as expected) rather than not maintained? 3 years doesn't seem too long to me.

JoshuaKGoldberg

Really cool work! I think long-term we'll need to migrate to the vfs (and I hope also adopt the globify-gitignore package) but short-term this is definitely a step forward from where we are now. Nicely done!

No blockers from me - just suggestions that we can do as followups IMO.

JoshuaKGoldberg · 2026-01-29T16:34:40Z

packages/core/src/running/createGitignoreFilter.ts

+	};
+}
+
+export const gitignoreFilter = createGitignoreFilter();


[Refactor] There's no need for this to be module-level state, right? I think it could be moved to inside computeUseDefinitions. Then it'd be a little more resilient to things changing between calls in --watch / multi-run mode.

JoshuaKGoldberg · 2026-01-29T16:40:06Z

packages/core/src/running/createGitignoreFilter.test.ts

+	beforeEach(() => {
+		fs.rmSync(integrationRoot, { force: true, recursive: true });
+		fs.mkdirSync(integrationRoot, { recursive: true });
+		vi.stubGlobal("process", { ...process, cwd: () => integrationRoot });


[Refactor] computeUseDefinitions already calls process.cwd() as well. Eventually we're likely to need to make all these functions work with a custom cwd / receive one from the calling host. How about changing createGitignoreFilter to take in a cwd: string?

Yeah, I don't think we need to mock it anymore.

JoshuaKGoldberg · 2026-01-29T16:42:45Z

packages/core/src/running/createGitignoreFilter.ts

@@ -0,0 +1,62 @@
+import { makeAbsolute } from "@flint.fyi/utils";
+import ignore from "ignore";
+import fs from "node:fs";


#1605 added a full linter host that we can use. It'll eventually be a must-have, to avoid node:fs access (e.g. for Flint running in a browser context). Do you have bandwidth to refactor this PR to have createGitignoreFilter take that in instead of calling to node:fs methods?

JoshuaKGoldberg · 2026-01-29T16:45:14Z

packages/core/src/running/createGitignoreFilter.ts

globify-gitignore doesn't have any open issues or PRs, so I think it might just be "done" (working as expected) rather than not maintained? 3 years doesn't seem too long to me.

JoshuaKGoldberg · 2026-01-29T16:46:20Z

cspell.json

 		"tsgolint",
 		"twoslash",
 		"typelang",
+		"unstub",


No longer needed?

Suggested change

"unstub",

I yearn for streetsidesoftware/cspell#2536...

Seems still need.

lishaduck

I'd held off approving to see if we cared about LinterHost, but if we're happy to leave that for a followup, then it LGTM 👍🏻

JoshuaKGoldberg · 2026-01-29T20:53:25Z

@kovsu marking as ready to merge - whatever you want to do, it's up to you. Cheers!

lishaduck

Loving it! 😍

lishaduck · 2026-01-31T04:27:46Z

packages/core/src/running/computeUseDefinitions.ts

 	log("Collecting files from %d use pattern(s)", configDefinition.use.length);

 	const allFilePaths = new Set<string>();
+	const gitignoreFilter = createGitignoreFilter(process.cwd(), host);


Suggested change

const gitignoreFilter = createGitignoreFilter(process.cwd(), host);

const gitignoreFilter = createGitignoreFilter(host.getCurrentWorkingDirectory(), host);

process.cwd() -> /User/xxx
linterhost.getCurrentDirectory() -> /user/xxx

when i use path.relative(), it throw an error.

Well, that's a bug... uh... can you take a look why? It definitely shouldn't be lowercase 🤔

CC @auvred in case I'm wrong

lishaduck · 2026-01-31T04:28:05Z

packages/core/src/running/createGitignoreFilter.test.ts

+	beforeEach(() => {
+		fs.rmSync(integrationRoot, { force: true, recursive: true });
+		fs.mkdirSync(integrationRoot, { recursive: true });
+		vi.stubGlobal("process", { ...process, cwd: () => integrationRoot });


Yeah, I don't think we need to mock it anymore.

lishaduck · 2026-01-31T04:28:36Z

packages/core/src/running/createGitignoreFilter.ts

 	const ig = ignore();
 	const visited = new Set();
-	const rootDir = process.cwd();
+	const rootDir = cwd;


Suggested change

const rootDir = cwd;

lishaduck

I'm happy to leave figuring out the cwd thing for a followup. LGTM 👍🏻

kovsu added 2 commits January 27, 2026 16:28

feat(core): support nested .gitignore files in filtering

2da7488

add changeset

3a4b652

vercel bot deployed to Preview January 27, 2026 08:36 View deployment

kovsu marked this pull request as draft January 27, 2026 08:49

update

5368626

vercel bot deployed to Preview January 27, 2026 09:13 View deployment

fix ci

88d6b3a

kovsu marked this pull request as ready for review January 27, 2026 09:15

vercel bot deployed to Preview January 27, 2026 09:17 View deployment

JoshuaKGoldberg reviewed Jan 27, 2026

View reviewed changes

kovsu added 2 commits January 28, 2026 15:03

add test

6cbe010

??

dafe61f

vercel bot deployed to Preview January 28, 2026 07:05 View deployment

more test

d286b34

vercel bot deployed to Preview January 28, 2026 07:47 View deployment

JoshuaKGoldberg approved these changes Jan 29, 2026

View reviewed changes

JoshuaKGoldberg added the 1 approval One team member approved; we're now waiting for a second approval or for 2 business days to pass. label Jan 29, 2026

lishaduck approved these changes Jan 29, 2026

View reviewed changes

JoshuaKGoldberg added the ready to merge 2+ team members approved; we're now waiting on the author to file followups and self-merge. label Jan 29, 2026

update

e425c9d

vercel bot deployed to Preview January 30, 2026 01:56 View deployment

kovsu requested review from JoshuaKGoldberg and lishaduck January 30, 2026 01:56

lishaduck requested changes Jan 31, 2026

View reviewed changes

apply suggestion

571dc60

vercel bot deployed to Preview January 31, 2026 05:58 View deployment

lishaduck approved these changes Jan 31, 2026

View reviewed changes

	const gitignoreFilter = createGitignoreFilter(process.cwd(), host);
	const gitignoreFilter = createGitignoreFilter(host.getCurrentWorkingDirectory(), host);

feat(core): support nested .gitignore files in filtering #2156

Are you sure you want to change the base?

feat(core): support nested .gitignore files in filtering #2156

Uh oh!

Conversation

kovsu commented Jan 27, 2026

PR Checklist

Overview

Uh oh!

changeset-bot bot commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lishaduck left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg commented Jan 29, 2026

Uh oh!

lishaduck left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lishaduck left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Jan 27, 2026 •

edited

Loading

vercel bot commented Jan 27, 2026 •

edited

Loading

JoshuaKGoldberg left a comment •

edited

Loading