Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix rpc port config #66

Merged
merged 2 commits into from
Dec 9, 2024
Merged

chore: fix rpc port config #66

merged 2 commits into from
Dec 9, 2024

Conversation

KanishkKhurana
Copy link
Collaborator

Why?

minor port fix based on discussion

How?

remove DHT port and add pinger port

Copy link
Collaborator

@matthias-wright matthias-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthias-wright
Copy link
Collaborator

just realized the title says rpc port, but the rpc port wasn't changed. were you planning on changing the rpc port to the current testnet port?

@KanishkKhurana
Copy link
Collaborator Author

just realized the title says rpc port, but the rpc port wasn't changed. were you planning on changing the rpc port to the current testnet port?

Thanks for pointing that out. I have added the change here

Copy link
Collaborator

@matthias-wright matthias-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KanishkKhurana KanishkKhurana merged commit adae696 into develop Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants