Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screenshot location to builddir/files/share/app-info/media #169

Closed
wants to merge 1 commit into from
Closed

Update screenshot location to builddir/files/share/app-info/media #169

wants to merge 1 commit into from

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Dec 11, 2023

See #168

The location was changed in the libappstream port of flatpak-builder

flatpak/flatpak-builder@411da75

@bbhtt bbhtt marked this pull request as draft December 11, 2023 03:23
The location was changed in the libappstream port of flatpak-builder

flatpak/flatpak-builder@411da75
@TingPing
Copy link
Member

TingPing commented Feb 21, 2024

The contents of the two directories are different btw.

> tree _build/files/share/app-info/media/
└── com
    └── viber
        └── Viber.desktop
            └── 57afa5ae90ff56ff22f259783cfd3c37
                ├── icons
                │   └── 128x128
                │       └── com.viber.Viber.desktop.png
                └── screenshots
                    ├── image-1_224x214.png
                    └── image-1_orig.png
> tree _build2/screenshots/
└── com.viber.Viber-master
    ├── 112x63
    │   └── com.viber.Viber-29b4518dc53f788e03cacc3f0bb323bc.png
    ├── 1248x702
    ├── 1504x846
    ├── 224x126
    │   └── com.viber.Viber-29b4518dc53f788e03cacc3f0bb323bc.png
    ├── 624x351
    │   └── com.viber.Viber-29b4518dc53f788e03cacc3f0bb323bc.png
    └── 752x423
        └── com.viber.Viber-29b4518dc53f788e03cacc3f0bb323bc.png

@bbhtt
Copy link
Contributor Author

bbhtt commented Feb 22, 2024

It should work fine, appstream now generates the urls in catalogue as /media/com/viber/<hash>/screenshot/<image>

@bbhtt bbhtt closed this by deleting the head repository Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants