Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vte: Update vte-0.76.3.tar.xz to 0.77.0 #126

Closed
wants to merge 1 commit into from
Closed

Conversation

flathubbot
Copy link
Contributor

🤖 This pull request was automatically generated by flathub-infra/flatpak-external-data-checker. Please open an issue if you have any questions or complaints. 🤖

@flathubbot
Copy link
Contributor Author

Started test build 136853

@flathubbot
Copy link
Contributor Author

Build 136853 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/119889/org.gnome.gedit.flatpakref

@swilmet
Copy link
Collaborator

swilmet commented Jul 29, 2024

Is VTE 0.77.0 a stable version? I haven't found the information anywhere (readme, git tag, …). There is no NEWS or ChangeLog file.

@jbicha
Copy link
Collaborator

jbicha commented Jul 29, 2024

vte 0.77.0 is a development release. vte 0.78.0 will be the next major stable release as part of GNOME 47.

@TingPing
Copy link
Member

TingPing commented Aug 6, 2024

There must be a bug in the checker:

            x-checker-data:
              type: gnome
              name: vte
              stable-only: true

@swilmet
Copy link
Collaborator

swilmet commented Aug 6, 2024

There must be a bug in the checker

Indeed, it's because vte's major version is 0.

See https://github.com/flathub-infra/flatpak-external-data-checker/blob/master/src/checkers/gnomechecker.py

For the even/odd version scheme, the _is_stable() function checks if the major version is greater than 0. Look at the last if condition:

def _is_stable(version: str) -> bool:
    ver_list = version.split(".")
    if len(ver_list) < 2:
        # Single number, e.g. "41"
        return True
    major, minor = ver_list[:2]
    if set(ver_list[1:]) & {"alpha", "beta", "rc"}:
        return False
    if int(major) > 0 and int(major) < 40 and len(ver_list) > 2:
        return (int(minor) % 2) == 0
    # XXX If we didn't see any indication that the version is a prerelease,
    # assume it's a normal (stable) release
    return True

So it returns True in the case of vte (the last return, after the XXX comment).

@swilmet
Copy link
Collaborator

swilmet commented Aug 6, 2024

I've opened this issue:

flathub-infra/flatpak-external-data-checker#436

@jbicha
Copy link
Collaborator

jbicha commented Sep 10, 2024

I'm closing this since there are newer automatic pull requests. vte 0.78.0 should be released within a few days anyway.

@jbicha jbicha closed this Sep 10, 2024
@swilmet swilmet deleted the update-c8b3201 branch September 24, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants