-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source-git-branch exception-to pegasus frontend #485
base: master
Are you sure you want to change the base?
Add source-git-branch exception-to pegasus frontend #485
Conversation
No. commit+branch mean the build WILL fail as soon as the branch HEAD changes. There is no going around. Flathub is NOT for nightly builds. |
There is commit and a branch, currently: - type: git
url: https://github.com/mmatyas/pegasus-frontend.git
branch: master
commit: cc2497abf7ebb12e0cbdb57a16addaf62d6f50bd The goal is to update the commit to the latest one in master, which is the latest release. @mmatyas do you confirm that the latest commit in master is considered a stable release and not a nightly one? Otherwise, I guess an other release cycle will have to be found. |
Just drop specifying the branch? I’m not sure what you want to accomplish by setting both if the branch is rolling. |
Yes please, one that doesn't involve updating daily to a new commit or tag or whatever. If you want to do that, either update it with a custom workflow once a week like I mentioned in the original issue above or you are free to host it externally. Doing nightlies is not sustainable for the infra. |
Once a week sounds good, let's do like RPCS3. To have this flathub/org.pegasus_frontend.Pegasus#49 work, an exception will still be needed though? |
If I understand correctly the issue, this is more about the frequency of builds than the nature of the release? |
Frequency is a problem for the infra as well as having software that is not "stable". End users expect software from Flathub to be stable, Nightly belongs in upstream CI.
It's needed, can you update it to mention it's for x-checker, and a weekly custom workflow has been implemented. |
The latest stable release is the last commit with an annotated Git tag (see https://github.com/mmatyas/pegasus-frontend/releases). I assume this would require a daily-running script, but if it's too much trouble, I'm fine with a weekly workflow too. I also had good experience with externally hosting an auto-updated Flatpak release; we can set one up for nightlies if necessary. |
If you switch to those weekly_ tags, exception is not needed anymore. |
239b03a
to
9dced15
Compare
9dced15
to
bb85e96
Compare
What do we do then @mmatyas, have a weekly cron taking the latest commit with the |
Yes, that sounds good to me. |
Likely what's the maintainer @mmatyas wish to (flathub/org.pegasus_frontend.Pegasus#44).
Update: this is required for a weekly update x-checker cron (flathub/org.pegasus_frontend.Pegasus#49)