Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source-git-branch exception-to pegasus frontend #485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

j8r
Copy link

@j8r j8r commented Sep 28, 2024

Likely what's the maintainer @mmatyas wish to (flathub/org.pegasus_frontend.Pegasus#44).

Update: this is required for a weekly update x-checker cron (flathub/org.pegasus_frontend.Pegasus#49)

@hfiguiere
Copy link
Contributor

No. commit+branch mean the build WILL fail as soon as the branch HEAD changes. There is no going around.

Flathub is NOT for nightly builds.

@j8r
Copy link
Author

j8r commented Sep 28, 2024

There is commit and a branch, currently:

 - type: git
   url: https://github.com/mmatyas/pegasus-frontend.git
   branch: master
   commit: cc2497abf7ebb12e0cbdb57a16addaf62d6f50bd

The goal is to update the commit to the latest one in master, which is the latest release.
If not possible, we'll have to find another workaround then...

@mmatyas do you confirm that the latest commit in master is considered a stable release and not a nightly one? Otherwise, I guess an other release cycle will have to be found.

@barthalion
Copy link
Member

Just drop specifying the branch? I’m not sure what you want to accomplish by setting both if the branch is rolling.

@bbhtt bbhtt added exceptions Request to add exceptions blocked labels Sep 29, 2024
@bbhtt
Copy link
Contributor

bbhtt commented Sep 29, 2024

I guess an other release cycle will have to be found.

Yes please, one that doesn't involve updating daily to a new commit or tag or whatever.

If you want to do that, either update it with a custom workflow once a week like I mentioned in the original issue above or you are free to host it externally.

Doing nightlies is not sustainable for the infra.

@j8r
Copy link
Author

j8r commented Sep 29, 2024

Once a week sounds good, let's do like RPCS3. To have this flathub/org.pegasus_frontend.Pegasus#49 work, an exception will still be needed though?
Or, we'll have to make a custom script for that purpose 🤔

@j8r
Copy link
Author

j8r commented Sep 29, 2024

If I understand correctly the issue, this is more about the frequency of builds than the nature of the release?
For example, a stable release per day is more problematic than a nightly build per month.

@bbhtt
Copy link
Contributor

bbhtt commented Sep 29, 2024

Frequency is a problem for the infra as well as having software that is not "stable". End users expect software from Flathub to be stable, Nightly belongs in upstream CI.

an exception will still be needed though?

It's needed, can you update it to mention it's for x-checker, and a weekly custom workflow has been implemented.

@mmatyas
Copy link

mmatyas commented Sep 29, 2024

@mmatyas do you confirm that the latest commit in master is considered a stable release and not a nightly one? Otherwise, I guess an other release cycle will have to be found.

The latest stable release is the last commit with an annotated Git tag (see https://github.com/mmatyas/pegasus-frontend/releases). I assume this would require a daily-running script, but if it's too much trouble, I'm fine with a weekly workflow too.

I also had good experience with externally hosting an auto-updated Flatpak release; we can set one up for nightlies if necessary.

@bbhtt
Copy link
Contributor

bbhtt commented Sep 30, 2024

If you switch to those weekly_ tags, exception is not needed anymore.

@bbhtt bbhtt force-pushed the add-source-git-branch-exception-to-pegasus-frontend branch from 239b03a to 9dced15 Compare October 30, 2024 14:18
@bbhtt bbhtt force-pushed the add-source-git-branch-exception-to-pegasus-frontend branch from 9dced15 to bb85e96 Compare October 30, 2024 18:57
@j8r
Copy link
Author

j8r commented Nov 12, 2024

What do we do then @mmatyas, have a weekly cron taking the latest commit with the continuous tag?

@mmatyas
Copy link

mmatyas commented Nov 12, 2024

Yes, that sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked exceptions Request to add exceptions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants