ci-automation/vms: Export official release variable #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ci-cleanup file gets created in ci-automation/ to remove any leftovers when a build gets stopped. Since it is in the git tree, git status sees untracked files which is a bit confusing. Ignore the ci-cleanup file.
pothos
force-pushed
the
kai/fix-build-sysext
branch
from
16f91c0
to
d2a2a5e
Compare
The official release variable is used to decide whether a build ID gets appended to the FLATCAR_VERSION (or VERSION in os-release) or not. It was set for the image job but not for the vms job, causing the build_sysext script to get the build ID appended to the FLATCAR_VERSION which causes a mismatch with the one from the image job. Set the official release variable in the vms job as well.
pothos
force-pushed
the
kai/fix-build-sysext
branch
from
d2a2a5e
to
095ab23
Compare
dongsupark
approved these changes
Jul 17, 2023
sayanchowdhury
approved these changes
Jul 17, 2023
pothos
added a commit
that referenced
this pull request
Jul 17, 2023
ci-automation/vms: Export official release variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official release variable is used to decide whether a build ID gets
appended to the FLATCAR_VERSION (or VERSION in os-release) or not. It
was set for the image job but not for the vms job, causing the
build_sysext script to get the build ID appended to the FLATCAR_VERSION
which causes a mismatch with the one from the image job.
Set the official release variable in the vms job as well.
How to use
Needed for the branched Alpha
Testing done
In the workspace of the vms job I ran this: