-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the url in get_sdk_binhost before echoing #979
Conversation
Can you squash the commits? |
Build action triggered: https://github.com/flatcar/scripts/actions/runs/5608133210 |
a2410d7
to
1cc5481
Compare
I've tried this PR and now the following warning is printed onto the console:
it only makes sense to merge this if it gets rid of this warning as well. |
1cc5481
to
d3fc7de
Compare
@jepio Hello, Jeremi. It appears that this error has also been resolved through my recent change. Please review it so that we can proceed with the merge. Thank you! |
This is not a fix that we can merge. We do rely on binpkgs (and these flags) during the sdk build, but not once the sdk is pushed to the container registry. So we can't take this shortcut and remove all these flags. You could deal with binhost being empty (or only whitespace) and then perform the necessary actions (not sure what exactly is needed to silence the warning): skip passing Sidenote: we don't merge main into PR branches, we rebase them. |
When running the build_packages script, one can encounter an error such as 'Error fetching binhost package info from.' This pertains to SDK packages (not board packages). Since we have transitioned to the SDK container, the SDK packages are no longer published independently from the container image.
be98e65
to
fadf4c2
Compare
There seem to be more similar messages but this is good enough to merge now. |
Check the url in get_sdk_binhost before echoing
Hi. When running the build_packages script, one can encounter an error such as 'Error fetching binhost package info from.' This pertains to SDK packages (not board packages). Since we have transitioned to the SDK container, the SDK packages are no longer published independently from the container image.
@jepio encouraged me to submit a pull request (PR) for the same