-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use build_sysext
for building OEM sysext images, drop old stuff
#969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
force-pushed
the
krnowak/test-new-oem-script
branch
from
July 5, 2023 06:40
e64f35b
to
58a18d6
Compare
krnowak
force-pushed
the
krnowak/test-new-oem-script
branch
from
July 5, 2023 06:43
58a18d6
to
2c1d892
Compare
CI passed. |
Build action triggered: https://github.com/flatcar/scripts/actions/runs/5463346150 |
@krishjainx can you please review this as well |
pothos
approved these changes
Jul 5, 2023
LGTM @krnowak. The report seems particularly useful as well so great addition |
Thanks. It's something the old script also did, but I forgot about it before. So added it for the feature parity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/2099/cldsv