Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEM: IONOS Cloud Images #100

Closed
wants to merge 5 commits into from
Closed

Conversation

tuunit
Copy link

@tuunit tuunit commented Oct 22, 2024

[Title: describe the change in one sentence]

[ describe the change in 1 - 3 paragraphs ]

How to use

[ describe what reviewers need to do in order to validate this PR ]

Testing done

[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

Comment on lines 42 to 44
if [ "${oem_cmdline}" = "ionoscloud" ]; then
oem_cmdline="qemu"
fi
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed when coreos/ignition#1957 is merged and released

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I would recommend to prepare the PR in his final state. I will kick off a test build with your Ignition patch.

@tuunit tuunit changed the title add ionoscloud support OEM: IONOS Cloud images Oct 23, 2024
@tuunit tuunit changed the title OEM: IONOS Cloud images OEM: IONOS Cloud Images Oct 23, 2024
@tuunit
Copy link
Author

tuunit commented Nov 4, 2024

No changes necessary for IONOS cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants