Reth 1.3.11 #176
Merged
Reth 1.3.11 #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
avalonche
reviewed
Apr 16, 2025
src/server.rs
Outdated
| (Ok(Some(builder)), _) => Ok((builder, PayloadSource::Builder)), | ||
| (_, Ok(l2)) => Ok((l2, PayloadSource::L2)), | ||
| (Ok(Some(builder)), Ok(l2)) => { | ||
| histogram!("block_building_gas_difference") |
Collaborator
There was a problem hiding this comment.
these can be defined in impl SpanProcessor for MetricsSpanProcessor { on the end of the call?
Contributor
There was a problem hiding this comment.
Moving this to a separate PR to unblock @cody-wang-cb , will move to processor
avalonche
reviewed
Apr 16, 2025
src/client/rpc.rs
Outdated
|
|
||
| if res.is_invalid() { | ||
| counter!(format!( | ||
| "rpc_new_payload_v4_invalid_payload_{}", |
Collaborator
There was a problem hiding this comment.
many of the metrics can be simplified by having the method name and payload source as an attribute
cody-wang-cb
force-pushed
the
cody/reth-1.3.9
branch
from
f3fe988 to
dac67b0
Compare
Merged
avalonche
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support reth 1.3.11