L-04 add missing reentrancy guard in FlashtestationRegistry:invalidat…#28
Merged
Melvillian merged 2 commits intomainfrom Aug 18, 2025
Merged
Conversation
…eAttestation This addresses the L-04 item of the Q3 2025 OZ audit Functions that register new TEE services have a reentrancy guard modifier because they do not follow the CEI pattern and rely on the external call verifyAndAttestOnChain from the attestation contract. While this call can be trusted because the attestation contract should not be malicious and is not upgradeable, there are situations where the execution is forwarded to the tx.origin. Hence, with the recent introduction of EIP-7702, it is possible for a malicious user to reenter the FlashtestationRegistry with an outdated state. For this reason, the reentrancy guard is completely necessary. However, while the invalidateAttestation function relies on this external call, it does not have the reentrancy guard protection. Hence, it is vulnerable to being reentered. Consider adding the nonReentrant modifier to the invalidateAttestation function.
Melvillian
force-pushed
the
L-04/missing-reentrancy-guard-in-invalidateAttestation
branch
from
4f71253 to
c719a4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eAttestation
This addresses the L-04 item of the Q3 2025 OZ audit
Functions that register new TEE services have a reentrancy guard modifier because they do not follow the CEI pattern and rely on the external call verifyAndAttestOnChain from the attestation contract. While this call can be trusted because the attestation contract should not be malicious and is not upgradeable, there are situations where the execution is forwarded to the tx.origin.
Hence, with the recent introduction of EIP-7702, it is possible for a malicious user to reenter the FlashtestationRegistry with an outdated state. For this reason, the reentrancy guard is completely necessary. However, while the invalidateAttestation function relies on this external call, it does not have the reentrancy guard protection. Hence, it is vulnerable to being reentered.
Consider adding the nonReentrant modifier to the invalidateAttestation function.