Adjusts validate for custom recipes lost during rebasing#362
Open
Ruteri wants to merge 1 commit intoflashbots:mainfrom
Open
Adjusts validate for custom recipes lost during rebasing#362Ruteri wants to merge 1 commit intoflashbots:mainfrom
Ruteri wants to merge 1 commit intoflashbots:mainfrom
Conversation
canercidam
reviewed
Feb 10, 2026
| return runValidation(yamlRecipe) | ||
| } | ||
|
|
||
| // Check if it's a custom recipe name |
Collaborator
There was a problem hiding this comment.
Shall we do this in a test case? I guess it's better to not ship if a custom recipe looks broken. 🙂 (I think the validation still makes sense for the local file, like above)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation for custom recipes now aligned with how the other commands handle it. Lost during rebase.