minor code review improvements

flash-oss · Nov 29, 2023 · ab170c5 · ab170c5
1 parent 5bd9141
commit ab170c5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/spec/book.spec.ts b/spec/book.spec.ts
@@ -625,7 +625,6 @@ describe("book", function () {
     it("should reuse the snapshot listAccounts", async () => {
       const book = new Book("MyBook-listAccounts-snapshot");
       await addBalance(book);
-      // await snapshotListAccounts({ book: book.name, accounts: ["a", "b"], createdAt: new Date(), expireInSec: 1 });
 
       await book.listAccounts();
 

diff --git a/src/Book.ts b/src/Book.ts
@@ -44,7 +44,7 @@ function fromDistinctToAccounts(distinctResult: string[]) {
     }
   }
 
-  return accountsSet;
+  return Array.from(accountsSet);
 }
 
 export class Book<U extends ITransaction = ITransaction, J extends IJournal = IJournal> {
@@ -367,14 +367,12 @@ export class Book<U extends ITransaction = ITransaction, J extends IJournal = IJ
       session: options.session,
     })) as string[];
 
-    let accountsSet: Set<string> = fromDistinctToAccounts(results);
+    let uniqueAccounts = fromDistinctToAccounts(results);
 
     if (listAccountsSnapshot) {
-      accountsSet = new Set([...accountsSet, ...listAccountsSnapshot.meta.accounts]);
+      uniqueAccounts = Array.from(new Set([...uniqueAccounts, ...listAccountsSnapshot.meta.accounts]));
     }
 
-    const uniqueAccounts = Array.from(accountsSet);
-
     if (uniqueAccounts.length === 0) return uniqueAccounts;
 
     if (this.balanceSnapshotSec) {
@@ -408,7 +406,7 @@ export class Book<U extends ITransaction = ITransaction, J extends IJournal = IJ
             .then((results) => {
               return snapshotListAccounts({
                 book: this.name,
-                accounts: Array.from(fromDistinctToAccounts(results)),
+                accounts: fromDistinctToAccounts(results),
                 createdAt,
                 expireInSec: this.expireBalanceSnapshotSec,
               });