Randomize pass if value is empty. Override if secret is specified#141
Open
scottrigby wants to merge 1 commit intoflanksource:mainfrom
Open
Randomize pass if value is empty. Override if secret is specified#141scottrigby wants to merge 1 commit intoflanksource:mainfrom
scottrigby wants to merge 1 commit intoflanksource:mainfrom
Conversation
Signed-off-by: Scott Rigby <scott@r6by.com>
55f3093 to
8bbf403
Compare
moshloop
reviewed
Jan 25, 2024
Comment on lines
+111
to
+120
| admin: | ||
| # If you leave this empty, and do not override with admin.existingSecret, a | ||
| # random password will be generated for you. | ||
| password: "" | ||
| # Specifying an existing secret name will override the admin.password. | ||
| # The secret key must be "admin-password" | ||
| # For example, to create from a file: | ||
| # echo -n 'S!B\*d$zDsb=' > ./admin-password.txt | ||
| # kubectl create secret generic admin-password-secret --from-file=admin-password.txt | ||
| existingSecret: "" |
Member
There was a problem hiding this comment.
I think we can skip passing in a plaintext password, if you want to specify a password then you must create the secret before and set create: false
Suggested change
| admin: | |
| # If you leave this empty, and do not override with admin.existingSecret, a | |
| # random password will be generated for you. | |
| password: "" | |
| # Specifying an existing secret name will override the admin.password. | |
| # The secret key must be "admin-password" | |
| # For example, to create from a file: | |
| # echo -n 'S!B\*d$zDsb=' > ./admin-password.txt | |
| # kubectl create secret generic admin-password-secret --from-file=admin-password.txt | |
| existingSecret: "" | |
| adminPassword: | |
| secretKeyRef: | |
| create: true # set to false if you want to pass in an existing secret | |
| name: mission-control-admin-password | |
| key: password |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #139
Notes to reviewers
This PR also deprecates
adminPasswordwith a deprecation note invalues.yamland_helpers.tplthat it will be removed in a future version.For now the PR changes that to:
Mainly because I felt
adminPasswordExistingSecretwould be a bit long. But can change that back if you prefer.To-do: