feat: On schema changes, push the JSON schema to claude-skills repo#1857
feat: On schema changes, push the JSON schema to claude-skills repo#1857adityathebe wants to merge 2 commits intomainfrom
Conversation
|
Warning Rate limit exceeded@adityathebe has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 51 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughA new GitHub Actions workflow is added to automate syncing local config schema files into the claude-code-plugin repository. The workflow triggers on schema file changes or manual dispatch, performs repository checkouts, syncs files via rsync, and commits the changes. Changes
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.github/workflows/sync-claude-schemas.yml:
- Around line 3-7: The push trigger currently watches
config/schemas/config_*.schema.json across all branches; restrict it to the main
branch by adding a branches filter under the push trigger (e.g., add "branches:"
with "- main" nested alongside "paths") so the workflow only runs for pushes to
main that modify those schema files.
- Around line 9-14: Add an explicit permissions block to the GitHub Actions
workflow (for the job named "sync") to avoid default token perms; update the
workflow to include a minimal permissions entry (e.g., permissions: contents:
read) at the job or top level so the Checkout config-db step (uses:
actions/checkout@...) only receives read access to repository contents and no
broader default permissions.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/sync-claude-schemas.yml
🧰 Additional context used
🪛 GitHub Check: CodeQL
.github/workflows/sync-claude-schemas.yml
[warning] 11-33: Workflow does not contain permissions
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{contents: read}}
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (1)
.github/workflows/sync-claude-schemas.yml (1)
23-33: Sync and commit logic looks correct.The rsync with
--deleteensures the target directory mirrors the source exactly. The git-auto-commit-action will commit to the default branch of claude-code-plugin.Consider adding
branchparameter to explicitly target the main branch in the target repository for clarity, though the default behavior should work correctly.Optional: explicit branch targeting
- name: Push changes to claude-code-plugin uses: stefanzweifel/git-auto-commit-action@28e16e81777b558cc906c8750092100bbb34c5e3 # v7.0.0 with: commit_message: "chore: sync config scraper schemas" repository: ./claude-code-plugin + branch: main
…rmissions - Only trigger on main branch to prevent syncs from feature branches - Add explicit permissions block (contents: read) following security best practices - Add explicit branch parameter to git-auto-commit-action for clarity
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.