Draft
Conversation
Member
|
LGTM, @moshloop please have a second look |
moshloop
reviewed
Mar 1, 2023
| if result.Costs != nil { | ||
| gormDB := db.DefaultDB() | ||
| var accountTotal1h, accountTotal1d, accountTotal7d, accountTotal30d float64 | ||
| for _, item := range result.Costs.LineItems { |
Member
There was a problem hiding this comment.
I think this is missing external_type, Did we also not extract this into a common clause so that we con't have to keep repeating it ?
Member
Author
There was a problem hiding this comment.
@moshloop external type wasn't being used in aws/cost.go which is where this code comes from. Should I add it?
Member
Author
|
On hold for now because we might need to add a separate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Coststo Scrape Result.