add complex return detection for nvfortran #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
historically, PGI->NVHPC Fortran has used the Intel convention. this is true on x86_64 and ppc64le, and has been true on aarch64. however, starting with the 23.9 release, on the aarch64 platform, nvfortran will switch to the gfortran convention. this patch adds the appropriate logic to configure. this patch has not been tested at all. i am relying on CI for that. Signed-off-by: Jeff Hammond <[email protected]>
|
@jeffhammond Let me know when you feel good about calling this PR done, and I'll merge. |
|
I need to test a few places and haven't had time but I'll let you know when it's validated everywhere relevant. |
|
@jeffhammond any update on this? |
|
thanks for the reminder. i do not remember what i did so i'll have to try again. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
historically, PGI->NVHPC Fortran has used the Intel convention. this is true on x86_64 and ppc64le, and has been true on aarch64. however, starting with the 23.9 release, on the aarch64 platform, nvfortran will switch to the gfortran convention.
this patch adds the appropriate logic to configure. this patch has not been tested at all. i am relying on CI for that.
sort of related to #433