Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attribute options rules issue #65

Merged
merged 7 commits into from
Sep 28, 2021
Merged

Fix attribute options rules issue #65

merged 7 commits into from
Sep 28, 2021

Conversation

flagbird
Copy link
Collaborator

Fixes #62

@flagbird flagbird added this to the 5.0.1 milestone Sep 21, 2021
@flagbird flagbird closed this Sep 21, 2021
@flagbird flagbird reopened this Sep 21, 2021
@flagbird flagbird added the bug Something isn't working label Sep 21, 2021
amansilla
amansilla requested changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@amansilla amansilla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code can be improved. Waiting for @flagbird's feedback.

  • Locally tested code works as intended ✅

src/Controller/AjaxOptionController.php Outdated Show resolved Hide resolved
@amansilla
Copy link
Contributor

@pascal-zarrad FYI: This PR should be tested using Akeneo EE, since rules are only in EE included.

@flagbird
Copy link
Collaborator Author

master should have been rebased into this branch. The button on GitHub PR pages to update a branch does only merge. :-/

@amansilla
Copy link
Contributor

master should have been rebased into this branch. The button on GitHub PR pages to update a branch does only merge. :-/

Yeah not nice for the git history maybe we can check if we can change that on repo configuration.

@flagbird flagbird requested a review from Vogaeael September 28, 2021 10:30
Vogaeael
Vogaeael approved these changes Sep 28, 2021
View reviewed changes
Copy link

@Vogaeael Vogaeael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@flagbird flagbird merged commit 6501bc9 into master Sep 28, 2021
@flagbird flagbird deleted the fix-attribute-options-rules branch September 28, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vogaeael Vogaeael Vogaeael approved these changes

@amansilla amansilla amansilla approved these changes

@pascal-zarrad pascal-zarrad Awaiting requested review from pascal-zarrad

Assignees

@amansilla amansilla

@pascal-zarrad pascal-zarrad

Labels
bug Something isn't working size/L
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.

Error when selecting AttributeOption within Rules configuration (Akeneo 5.0.43)
4 participants
@flagbird @amansilla @Vogaeael @pascal-zarrad