Add support for Akeneo 3.0 #18

AngelVazquezArroyo · 2019-05-27T10:21:04Z

No description provided.

flagbird

A first simple test of creating, editing and using the table attribute in a product worked. Export and import was able to create the table attribute values.

We should use custom translation ids instead of Akeneo's. This can be done in a separate PR but before a 3.0 release.
A few specs are still missing. Please add them for the changed PHP files. Integrations are already handled by Integration Testing for Akeneo recognizing the tagged services #17.

.travis.yml

README.md

src/Form/Extension/AttributeOptionTypeExtension.php

src/Resources/config/doctrine.xml

src/Resources/config/services.xml

src/Validator/Constraints/AttributeTypeForOptionValidator.php

src/Validator/Constraints/TableValidator.php

src/Normalizer/AttributeOptionNormalizer.php

Co-Authored-By: claudioflagbit <[email protected]>

Co-Authored-By: flagbird <[email protected]>

AngelVazquezArroyo · 2019-06-24T10:13:02Z

Please be consistent in the Specs methods with the scope. Either use public or omit it. I personally prefer methods with scope

I created Tests need to be checked by static code analysis tools #27 for adding static analysis for tests, because adding it here would be out of scope

Spec method names have to be absolute: No "should", "could" or "maybe". Do or do not. There is no try. The names will be used in the output of failing tests.

@flagbird This PR is ready again fora new review.

Co-Authored-By: Amit Singh <[email protected]>

flagbird

This PR is ready again fora new review.

Not all of the previous changes were done. This PR is not ready for another review.

Here are additional changes:

CHANGELOG-3.0.md

spec/Flagbit/Bundle/TableAttributeBundle/Form/TableJsonTransformerSpec.php

src/Resources/config/array_converters.xml

spec/Flagbit/Bundle/TableAttributeBundle/AttributeType/TableTypeSpec.php

spec/Flagbit/Bundle/TableAttributeBundle/DependencyInjection/ConfigurationSpec.php

Co-Authored-By: flagbird <[email protected]>

AngelVazquezArroyo · 2019-06-25T12:52:57Z

@flagbird PR is ready to be again reviewed.

Co-Authored-By: flagbird <[email protected]>

spec/Flagbit/Bundle/TableAttributeBundle/Provider/Field/TableFieldProviderSpec.php

spec/Flagbit/Bundle/TableAttributeBundle/Normalizer/AttributeOptionNormalizerSpec.php

flagbird

This should be sufficiant for a first 3.0 Release.

More details on coding style for tests and specs can be done in #27.

amansilla

Thanks for the huge effort guys!

AngelVazquezArroyo requested review from ruben-beglaryan, flagbird and amansilla May 27, 2019 10:21

flagbird requested changes May 27, 2019

View reviewed changes

AngelVazquezArroyo force-pushed the 3.0 branch 4 times, most recently from 5d0e3f2 to deb32da Compare May 28, 2019 15:40

Ruben Beglaryan and others added 19 commits June 13, 2019 12:28

Migrate code to 3.0 #12

1187e73

Fixed version constraint #12

72beb58

Migrate service overrides to 3.0 #12

d771dc8

Remove unused event listener #12

40c7bca

Update data transformation for constraints and type_config #12

a800a57

Add AttributeTypeForOptionValidator definition as service #12

d99c4ba

Update translations #12

60b0884

Delete old php version for travis environment #12

d420248

Adding a higher priority for ConfigureMappingsSubscribe #12

05b4db6

Fix code sniffer error #12

daa3952

Update README for version 3.0 #12

59d697e

Add PHP7.3 on Travis environent and update dependencies #12

4844a64

Update README.md #12

505e6d6

Co-Authored-By: claudioflagbit <[email protected]>

Add comment for workaround, add separation for services #12

4dc8635

Delete auto generated author annotations #12

935b25a

Add physical json transformer #12

1e31798

Fix wrong return type on comment #12

d57bb97

Delete unused normalizer #12

a2ca054

Config for unittest environment migrated to 3.0

d68616f

ruben-beglaryan force-pushed the 3.0 branch from 89237d0 to ae9e076 Compare June 13, 2019 13:07

AngelVazquezArroyo force-pushed the 3.0 branch from 6f77203 to 2a27ea4 Compare June 13, 2019 16:31

amansilla changed the title ~~3.0~~ Add support for Akeneo 3.0 Jun 13, 2019

AngelVazquezArroyo and others added 4 commits June 24, 2019 10:34

Update AttributeOptionNormalizerSpec #12

453589a

Co-Authored-By: flagbird <[email protected]>

Add missing spec methods scope and update spec methods naming #12

fe03618

Update README.md #12

f041440

Co-Authored-By: flagbird <[email protected]>

Replace deprecated methods #12

e393d9f

AngelVazquezArroyo force-pushed the 3.0 branch from 6240aea to e393d9f Compare June 24, 2019 08:35

AngelVazquezArroyo force-pushed the 3.0 branch from fa58335 to 9b0dafd Compare June 24, 2019 10:20

AngelVazquezArroyo and others added 2 commits June 24, 2019 12:20

Add BC breaks info on changelog #12

c3a72d3

Add PHPSpec tests for TableJsonTransformer #12

4971b3b

Co-Authored-By: Amit Singh <[email protected]>

AngelVazquezArroyo force-pushed the 3.0 branch from 9b0dafd to 4971b3b Compare June 24, 2019 10:21

flagbird requested changes Jun 25, 2019

View reviewed changes

AngelVazquezArroyo force-pushed the 3.0 branch from af8368c to 905b6d8 Compare June 25, 2019 12:40

AngelVazquezArroyo and others added 3 commits June 25, 2019 14:44

Update text for BC breaks in CHANGELOG-3.0.md #12

a4b4cdb

Co-Authored-By: flagbird <[email protected]>

Update php spec methods #12

9afd2e1

Add type safety on in array #12

6d50cba

AngelVazquezArroyo force-pushed the 3.0 branch from dc8f1da to 6d50cba Compare June 25, 2019 12:45

Add space between services definition to do it more readable #12

63b3954

AngelVazquezArroyo and others added 3 commits June 25, 2019 15:21

Delete commented configuration #12

56fab52

Add more readable format instead in one line #12

d3dd3a1

Delete unused variable and unnecessary line #12

3b314a1

Co-Authored-By: flagbird <[email protected]>

AngelVazquezArroyo force-pushed the 3.0 branch from 7161f1e to 3b314a1 Compare June 25, 2019 13:44

amitflagbit and others added 2 commits June 26, 2019 10:08

Update specs for TableFieldProvider #12

535b209

Update spec tests #12

ab49ec3

flagbird requested changes Jun 26, 2019

View reviewed changes

Update consisting coding style for spec tests #12

a422b78

flagbird approved these changes Jun 26, 2019

View reviewed changes

amansilla approved these changes Jun 27, 2019

View reviewed changes

amansilla merged commit db270ff into master Jun 27, 2019

amansilla deleted the 3.0 branch June 27, 2019 07:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Akeneo 3.0 #18

Add support for Akeneo 3.0 #18

AngelVazquezArroyo commented May 27, 2019

flagbird left a comment

AngelVazquezArroyo commented Jun 24, 2019

flagbird left a comment •

edited

Loading

AngelVazquezArroyo commented Jun 25, 2019

flagbird left a comment

amansilla left a comment

Add support for Akeneo 3.0 #18

Add support for Akeneo 3.0 #18

Conversation

AngelVazquezArroyo commented May 27, 2019

flagbird left a comment

Choose a reason for hiding this comment

AngelVazquezArroyo commented Jun 24, 2019

flagbird left a comment • edited Loading

Choose a reason for hiding this comment

AngelVazquezArroyo commented Jun 25, 2019

flagbird left a comment

Choose a reason for hiding this comment

amansilla left a comment

Choose a reason for hiding this comment

flagbird left a comment •

edited

Loading