Skip to content

Commit

Permalink
Merge pull request #31 from flagbit/fix-form-issue
Browse files Browse the repository at this point in the history
Fix compatibility with Akeneo >= 2.3.44 & < 3.0
  • Loading branch information
Antonio Mansilla authored Sep 23, 2019
2 parents 3fbb6d9 + 0269817 commit ad257f2
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ matrix:
include:
- php: 7.1
- php: 7.2
allow_failures:
- php: 7.2

before_install:
# disable default memory limit
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG-2.1.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# 2.1.5

## Bug fixes

- Fixes issue saving Akeneo AttributeOptions. #28

# 2.1.2

## Bug fixes
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ All product information related to attributes of type _table_ will be imported/e
Simply install the package with the following command:

``` bash
composer require flagbit/table-attribute-bundle
composer require flagbit/table-attribute-bundle:^2.1@stable
```

### Enable the bundle
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
}
],
"require": {
"akeneo/pim-community-dev": "^2.0.5"
"akeneo/pim-community-dev": "^2.3.41"
},
"require-dev": {
"phpspec/phpspec": "^4.2",
Expand Down
5 changes: 3 additions & 2 deletions src/Form/Extension/AttributeOptionTypeExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Flagbit\Bundle\TableAttributeBundle\Form\Extension;

use Pim\Bundle\EnrichBundle\Form\Type\AttributeOptionType;
use Pim\Bundle\FilterBundle\Form\Type\UnstructuredType;
use Symfony\Component\Form\AbstractTypeExtension;
use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Component\Form\FormBuilderInterface;
Expand All @@ -26,8 +27,8 @@ public function buildForm(FormBuilderInterface $builder, array $options)
new Choice(['select', 'select_from_url', 'text', 'number']),
],
]);
$builder->add('constraints', TextType::class, ['required' => true]);
$builder->add('type_config', TextType::class, ['required' => true]);
$builder->add('constraints', UnstructuredType::class, ['required' => true]);
$builder->add('type_config', UnstructuredType::class, ['required' => true]);
}

/**
Expand Down

0 comments on commit ad257f2

Please sign in to comment.