Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for mathjs AST #654

Merged
merged 1 commit into from
Jul 2, 2022
Merged

feat: add support for mathjs AST #654

merged 1 commit into from
Jul 2, 2022

Conversation

mattvague
Copy link
Contributor

Adds support for ASTs generated by http://mathjs.org

@mattvague mattvague changed the title Add support for mathjs AST feat: add support for mathjs AST Jun 13, 2022
@fkling fkling merged commit 2ea36e9 into fkling:master Jul 2, 2022
@fkling
Copy link
Owner

fkling commented Jul 2, 2022

Nice! It doesn't look like the AST contains positioning information, so it can't be corrolated with the source code. It would be nice if this supported or enabled eventually.

@fkling fkling added the deployed to production Marks issues/PRs that are deployed to https://astexplorer.net label Jul 2, 2022
@mattvague mattvague mentioned this pull request Jul 2, 2022
Draft
@mattvague
Copy link
Contributor Author

@fkling Sweet, thanks! I've started on a PR adding positional information to the AST here but will need some help from the lib author. Will create a new PR here to add support once that's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deployed to production Marks issues/PRs that are deployed to https://astexplorer.net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattvague @fkling