Replace private node handle with regular one #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyromarock
pushed a commit
to UniBwTAS/camera_aravis
that referenced
this pull request
May 19, 2022
* Add GitHub Actions file * Add aravis to package.xml * Fix catkin install error (dynamic_reconfigure headers not found) * Rename README.markdown to README.md * Add badge to README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We believe it is much more common to advertise/publish messages using a regular node handle, such that the own node name is not necessarily part of the published topic. The official tutorial also uses regular node handles.
With this change the full topic can be easily controlled by the ns attribute in the launch file, e.g. with
ns="sensors/camera_front"the topics will be/sensors/camera_front/camera_infoand/sensors/camera_front/image_rawno matter how the name of the node is.