[Lifter] Fix tailcall lifting (#61)

* Fix spelling error * Add testcase for tailcall
fkie-cad · Feb 15, 2022 · 93ddcab · 93ddcab
1 parent d39078b
commit 93ddcab
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/decompiler/frontend/binaryninja/handlers/calls.py b/decompiler/frontend/binaryninja/handlers/calls.py
@@ -40,7 +40,7 @@ def lift_call(self, call: mediumlevelil.MediumLevelILCall, ssa: bool = False, **
                 [self._lifter.lift(parameter, parent=call) for parameter in call.params],
                 vartype=dest.type.copy(),
                 writes_memory=call.output_dest_memory if ssa else None,
-                meta_data={"param_names": self._lift_call_parameter_names(call), "is_failcall": isinstance(call, Tailcall)},
+                meta_data={"param_names": self._lift_call_parameter_names(call), "is_tailcall": isinstance(call, Tailcall)},
             ),
         )
 

diff --git a/tests/test_sample_binaries.py b/tests/test_sample_binaries.py
@@ -91,3 +91,11 @@ def test_global_import_address_symbol():
     assert output1.count("g_35_1 = &(g_35)") == 1
     assert output1.count("g_38 = ") == 1
     assert output1.count("g_38_1 = &(g_38)") == 1
+
+
+def test_tailcall_display():
+    """Test that we display tailcalls correctly."""
+    args = ["python", "decompile.py", "tests/coreutils/binaries/sha224sum", "rpl_fseeko"]
+    output = str(subprocess.run(args, check=True, capture_output=True).stdout)
+
+    assert output.count("return fseeko(") == 1