Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System version more plugins #1317

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Dec 12, 2024

@jstucke jstucke self-assigned this Dec 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 79.48718% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.82%. Comparing base (2aa83a0) to head (1ff0d2c).

Files with missing lines Patch % Lines
...ugins/analysis/cve_lookup/internal/data_parsing.py 52.94% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
- Coverage   92.34%   91.82%   -0.53%     
==========================================
  Files         379      378       -1     
  Lines       23465    21003    -2462     
==========================================
- Hits        21669    19285    -2384     
+ Misses       1796     1718      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maringuu
Copy link
Collaborator

What problem does this solve?
I do not quite understand how the system version is useful.

@jstucke
Copy link
Collaborator Author

jstucke commented Dec 18, 2024

What problem does this solve? I do not quite understand how the system version is useful.

It is useful for two things:

  • track the internal version of the data that the analysis is based on (since the outcome of the analysis may change based on this data)
  • if you run the analysis again with the same version of the plugin, it depends on the system version whether or not the analysis is run again or skipped (and since the outcome may change, it makes sense to update it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants