Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cwe-checker: add memory limit #1156

Merged
merged 1 commit into from
Oct 30, 2023
Merged

cwe-checker: add memory limit #1156

merged 1 commit into from
Oct 30, 2023

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Oct 30, 2023

  • adds an option for configuring a memory limit for the cwe_checker plugin
    • sets a default value of 4GB

@jstucke jstucke requested a review from Enkelmann October 30, 2023 09:25
@jstucke jstucke self-assigned this Oct 30, 2023
Enkelmann
Enkelmann approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Enkelmann Enkelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Although it could be unintuitive to users that removing the limits from the config toml will not actually remove the memory limits for the Docker containers. But right now this is probably for the best, as running the cwe_checker without any memory limits is currently not advisable.

@jstucke jstucke mentioned this pull request Oct 30, 2023
Open
@jstucke jstucke merged commit 740e9c2 into master Oct 30, 2023
@jstucke jstucke deleted the plugin-cwe-checker-limit-memory branch October 30, 2023 10:00
@jstucke jstucke mentioned this pull request Nov 7, 2023
Open
@jstucke jstucke mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enkelmann Enkelmann Enkelmann approved these changes

Assignees

@jstucke jstucke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstucke @Enkelmann