Exclude Fortify Source Check #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstucke
requested changes
Oct 27, 2023
|
Could you add the description of the PR in the commit message? |
…orming offline checks, as it doesn't function as expected in this context. The Fortify Source check operates by using the running system's libraries to check for the supported Fortify-able library functions. In the case of firmware, this approach is not applicable as the binary and the running system's libraries are not the same. Therefore, the Fortify Source check is removed for offline checks. There is a possibility that in the future, this check may be reinstated if a viable workaround is identified. This could involve leveraging the firmware's own libc through mechanisms like chroot, for instance.
jstucke
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
checksectool's Fortify Source check should be excluded when performing offline checks, as it doesn't function as expected in this context. The Fortify Source check operates by using the running system's libraries to check for the supported Fortify-able library functions. In the case of firmware, this approach is not applicable as the binary and the running system's libraries are not the same. Therefore, the Fortify Source check is removed for offline checks. (source)There is a possibility that in the future, this check may be reinstated if a viable workaround is identified. This could involve leveraging the firmware's own libc through mechanisms like chroot, for instance.