Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rest put firmware: unknown plugin fix #1148

Merged
merged 3 commits into from
Nov 7, 2023
Merged

rest put firmware: unknown plugin fix #1148

merged 3 commits into from
Nov 7, 2023

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Oct 19, 2023 •
edited
Loading

  • fixes a bug in route /rest/firmware put when submitting a firmware with unavailable plugins in 'requested_analysis_systems'
    • the "requested_analysis_systems" were not validated previously, leading to a KeyError during scheduling

resolves #1147

@jstucke jstucke added the bug label Oct 19, 2023
@jstucke jstucke requested a review from maringuu October 19, 2023 12:43
@jstucke jstucke self-assigned this Oct 19, 2023
@jstucke jstucke mentioned this pull request Oct 19, 2023
Closed
maringuu
maringuu approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@maringuu maringuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maringuu maringuu merged commit f3a9b0f into master Nov 7, 2023
11 checks passed
@maringuu maringuu deleted the rest-put-fw-unknown-plugin-fix branch November 7, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maringuu maringuu maringuu approved these changes

Assignees

@jstucke jstucke

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After uploading firmware with REST API error: KeyError: 'unpacker'
2 participants
@jstucke @maringuu