Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transformations support #392

Merged
merged 13 commits into from
Jan 28, 2025
Merged

Add transformations support #392

merged 13 commits into from
Jan 28, 2025

Conversation

fivetran-aleksandrboldyrev
Copy link
Contributor

No description provided.

Copy link
Collaborator

@beevital beevital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you.
But for QDM package transformation user can't update transformation_config.package_name and transformation_config.connection_ids - these are required on creation immutable fields.

They aren't marked as required in schema as there's more complex requirement: user must specify either one of these params on creation.

Basically these fields should be marked as "force new" in schema as changing leads to new transformation package creation.

Also I'd suggest to add more validations:

  • check if plan contains only fields related to particular transformation type (you can't set steps for QDM, but now it's possible and will lead to issues)
  • check for QDM if connection_ids are set or package_name specified.

For sure API will return error response on apply, but for example if I setup steps for qdm transformation - terraform apply will be successful, but then the state will be inconsistent (API won't return steps value back is it just ignored)

docs/data-sources/quickstart_packages.md Outdated Show resolved Hide resolved
fivetran/framework/resources/transformation.go Outdated Show resolved Hide resolved
templates/data-sources/quickstart_packages.md.tmpl Outdated Show resolved Hide resolved
templates/resources/transformation.md.tmpl Outdated Show resolved Hide resolved
templates/resources/transformation.md.tmpl Outdated Show resolved Hide resolved
templates/resources/transformation.md.tmpl Show resolved Hide resolved
templates/resources/transformation_project.md.tmpl Outdated Show resolved Hide resolved
templates/resources/transformation_project.md.tmpl Outdated Show resolved Hide resolved
fivetran/framework/resources/transformation.go Outdated Show resolved Hide resolved
fivetran/framework/core/schema/transformation_project.go Outdated Show resolved Hide resolved
fivetran/framework/resources/transformation_project.go Outdated Show resolved Hide resolved
@fivetran-aleksandrboldyrev fivetran-aleksandrboldyrev merged commit 832c731 into main Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants