Remove deprecated resources (#393)

CHANGELOG.md

@@ -25,6 +25,14 @@ Support for a new [Transformation Management API](https://fivetran.com/docs/rest
 - Datasources `fivetran_dbt_project`, `fivetran_dbt_projects`, `fivetran_dbt_transformation`, `fivetran_dbt_models`
 - Resources `fivetran_dbt_project`, `fivetran_dbt_transformation`
 
+## Breaking changes
+The deprecated resources, datasources and fields removed:
+- Resource `fivetran_local_processing_agent`.
+- Data source `fivetran_local_processing_agent`.
+- Data source `fivetran_local_processing_agents`.
+- Field `fivetran_connector.local_processing_agent_id`.
+- Field `fivetran_destination.local_processing_agent_id`.
+
 ## [1.4.2](https://github.com/fivetran/terraform-provider-fivetran/compare/v1.4.1...v1.4.2)
 
 ## Added

docs/data-sources/connector.md

@@ -33,7 +33,6 @@ data "fivetran_connector" "connector" {
 - `failed_at` (String) The timestamp of the time the connector sync failed last time.
 - `group_id` (String) The unique identifier for the Group (Destination) within the Fivetran system.
 - `hybrid_deployment_agent_id` (String) The hybrid deployment agent ID that refers to the controller created for the group the connection belongs to. If the value is specified, the system will try to associate the connection with an existing agent.
-- `local_processing_agent_id` (String) (Deprecated) The hybrid deployment agent ID that refers to the controller created for the group the connection belongs to. If the value is specified, the system will try to associate the connection with an existing agent.
 - `name` (String) The name used both as the connector's name within the Fivetran system and as the source schema's name within your destination.
 - `networking_method` (String) Possible values: Directly, SshTunnel, ProxyAgent.
 - `pause_after_trial` (Boolean) Specifies whether the connector should be paused after the free trial period has ended.

docs/data-sources/connectors.md

@@ -36,7 +36,6 @@ Read-Only:
 - `group_id` (String) The unique identifier for the Group (Destination) within the Fivetran system.
 - `hybrid_deployment_agent_id` (String) The hybrid deployment agent ID that refers to the controller created for the group the connection belongs to. If the value is specified, the system will try to associate the connection with an existing agent.
 - `id` (String) The unique identifier for the connector within the Fivetran system.
-- `local_processing_agent_id` (String) (Deprecated) The hybrid deployment agent ID that refers to the controller created for the group the connection belongs to. If the value is specified, the system will try to associate the connection with an existing agent.
 - `name` (String) The name used both as the connector's name within the Fivetran system and as the source schema's name within your destination.
 - `networking_method` (String) Possible values: Directly, SshTunnel, ProxyAgent.
 - `pause_after_trial` (Boolean) Specifies whether the connector should be paused after the free trial period has ended.

docs/data-sources/destination.md

@@ -27,7 +27,6 @@ data "fivetran_destination" "dest" {
 - `daylight_saving_time_enabled` (Boolean) Shift my UTC offset with daylight savings time (US Only)
 - `group_id` (String) The unique identifier for the Group within the Fivetran system.
 - `hybrid_deployment_agent_id` (String) The hybrid deployment agent ID that refers to the controller created for the group the connection belongs to. If the value is specified, the system will try to associate the connection with an existing agent.
-- `local_processing_agent_id` (String) (Deprecated) The hybrid deployment agent ID that refers to the controller created for the group the connection belongs to. If the value is specified, the system will try to associate the connection with an existing agent.
 - `networking_method` (String) Possible values: Directly, SshTunnel, ProxyAgent.
 - `private_link_id` (String) The private link ID.
 - `region` (String) Data processing location. This is where Fivetran will operate and run computation on data.

docs/data-sources/destinations.md

@@ -31,7 +31,6 @@ Read-Only:
 - `group_id` (String) The unique identifier for the Group within the Fivetran system.
 - `hybrid_deployment_agent_id` (String) The hybrid deployment agent ID that refers to the controller created for the group the connection belongs to. If the value is specified, the system will try to associate the connection with an existing agent.
 - `id` (String) The unique identifier for the destination within the Fivetran system.
-- `local_processing_agent_id` (String) (Deprecated) The hybrid deployment agent ID that refers to the controller created for the group the connection belongs to. If the value is specified, the system will try to associate the connection with an existing agent.
 - `networking_method` (String) Possible values: Directly, SshTunnel, ProxyAgent.
 - `private_link_id` (String) The private link ID.
 - `region` (String) Data processing location. This is where Fivetran will operate and run computation on data.

docs/resources/connector.md

@@ -73,7 +73,6 @@ resource "fivetran_connector" "amplitude" {
 - `data_delay_threshold` (Number) Custom sync delay notification threshold in minutes. The default value is 0. This parameter is only used when data_delay_sensitivity set to CUSTOM.
 - `destination_schema` (Block, Optional) (see [below for nested schema](#nestedblock--destination_schema))
 - `hybrid_deployment_agent_id` (String) The hybrid deployment agent ID that refers to the controller created for the group the connection belongs to. If the value is specified, the system will try to associate the connection with an existing agent.
-- `local_processing_agent_id` (String, Deprecated) (Deprecated) The hybrid deployment agent ID that refers to the controller created for the group the connection belongs to. If the value is specified, the system will try to associate the connection with an existing agent.
 - `networking_method` (String) Possible values: Directly, SshTunnel, ProxyAgent.
 - `private_link_id` (String) The private link ID.
 - `proxy_agent_id` (String) The proxy agent ID.

docs/resources/destination.md

@@ -49,7 +49,6 @@ resource "fivetran_destination" "dest" {
 - `config` (Block, Optional) (see [below for nested schema](#nestedblock--config))
 - `daylight_saving_time_enabled` (Boolean) Shift my UTC offset with daylight savings time (US Only)
 - `hybrid_deployment_agent_id` (String) The hybrid deployment agent ID that refers to the controller created for the group the connection belongs to. If the value is specified, the system will try to associate the connection with an existing agent.
-- `local_processing_agent_id` (String, Deprecated) (Deprecated) The hybrid deployment agent ID that refers to the controller created for the group the connection belongs to. If the value is specified, the system will try to associate the connection with an existing agent.
 - `networking_method` (String) Possible values: Directly, SshTunnel, ProxyAgent.
 - `private_link_id` (String) The private link ID.
 - `run_setup_tests` (Boolean) Specifies whether the setup tests should be run automatically. The default value is TRUE.

fivetran/framework/core/model/connector.go

@@ -39,7 +39,6 @@ type ConnectorDatasourceModel struct {
     ProxyAgentId             types.String `tfsdk:"proxy_agent_id"`
     NetworkingMethod         types.String `tfsdk:"networking_method"`
     HybridDeploymentAgentId  types.String `tfsdk:"hybrid_deployment_agent_id"`
-    LocalProcessingAgentId   types.String `tfsdk:"local_processing_agent_id"`
     PrivateLinkId            types.String `tfsdk:"private_link_id"`
     Status types.Object `tfsdk:"status"`
 
@@ -143,7 +142,6 @@ type ConnectorResourceModel struct {
 
 	ProxyAgentId           types.String `tfsdk:"proxy_agent_id"`
 	NetworkingMethod       types.String `tfsdk:"networking_method"`
-	LocalProcessingAgentId types.String `tfsdk:"local_processing_agent_id"`
     HybridDeploymentAgentId  types.String `tfsdk:"hybrid_deployment_agent_id"`
     PrivateLinkId          types.String `tfsdk:"private_link_id"`
 
@@ -231,12 +229,6 @@ func (d *ConnectorResourceModel) ReadFromContainer(c ConnectorModelContainer, fo
         d.DataDelayThreshold = types.Int64Null()
     }
 
-	if c.LocalProcessingAgentId != "" && !d.LocalProcessingAgentId.IsUnknown() && !d.LocalProcessingAgentId.IsNull(){
-		d.LocalProcessingAgentId = types.StringValue(c.HybridDeploymentAgentId)
-	} else {
-		d.LocalProcessingAgentId = types.StringNull()
-	}
-
 	if c.HybridDeploymentAgentId != "" {
 		d.HybridDeploymentAgentId = types.StringValue(c.HybridDeploymentAgentId)
 	} else {
@@ -305,12 +297,6 @@ func (d *ConnectorDatasourceModel) ReadFromContainer(c ConnectorModelContainer)
 		d.NetworkingMethod = types.StringValue(c.NetworkingMethod)
 	}
 
-	if c.HybridDeploymentAgentId != "" {
-		d.LocalProcessingAgentId = types.StringValue(c.HybridDeploymentAgentId)
-	} else {
-		d.LocalProcessingAgentId = types.StringNull()
-	}
-
     if c.HybridDeploymentAgentId != "" {
         d.HybridDeploymentAgentId = types.StringValue(c.HybridDeploymentAgentId)
     } else {
@@ -340,7 +326,6 @@ type ConnectorModelContainer struct {
     ProxyAgentId            string
     NetworkingMethod        string
     HybridDeploymentAgentId string
-    LocalProcessingAgentId  string
     PrivateLinkId           string
 
     DataDelaySensitivity string
@@ -379,10 +364,6 @@ func (c *ConnectorModelContainer) ReadFromResponseData(data connectors.DetailsRe
         c.PrivateLinkId = data.PrivateLinkId
 	}
 
-	if data.HybridDeploymentAgentId != "" && c.LocalProcessingAgentId != "" {
-		c.LocalProcessingAgentId = data.HybridDeploymentAgentId
-	}
-
     if data.HybridDeploymentAgentId != "" {
         c.HybridDeploymentAgentId = data.HybridDeploymentAgentId
     }

fivetran/framework/core/model/connectors.go

@@ -34,7 +34,6 @@ func (d *Connectors) ReadFromResponse(ctx context.Context, resp connectors.Conne
         "data_delay_threshold":         types.Int64Type,
         "proxy_agent_id":               types.StringType,
         "networking_method":            types.StringType,
-        "local_processing_agent_id":    types.StringType,
         "hybrid_deployment_agent_id":   types.StringType,
         "private_link_id":              types.StringType,
     }
@@ -65,7 +64,6 @@ func (d *Connectors) ReadFromResponse(ctx context.Context, resp connectors.Conne
         item["data_delay_threshold"] = types.Int64Value(int64(*v.DataDelayThreshold))
         item["proxy_agent_id"] = types.StringValue(v.ProxyAgentId)
         item["networking_method"] = types.StringValue(v.NetworkingMethod)
-        item["local_processing_agent_id"] = types.StringValue(v.HybridDeploymentAgentId)
         item["hybrid_deployment_agent_id"] = types.StringValue(v.HybridDeploymentAgentId)
         item["private_link_id"] = types.StringValue(v.PrivateLinkId)
 

fivetran/framework/core/model/destination.go

@@ -12,7 +12,6 @@ type destinationModel interface {
 	SetTimeZonOffset(string)
 	SetSetupStatus(string)
 	SetDaylightSavingTimeEnabled(bool)
-	SetLocalProcessingAgentId(string)
 	SetHybridDeploymentAgentId(string)
 	SetNetworkingMethod(string)
     SetPrivateLinkId(string)
@@ -27,7 +26,6 @@ func readFromResponse(d destinationModel, resp destinations.DestinationDetailsBa
 	d.SetSetupStatus(resp.SetupStatus)
 	d.SetTimeZonOffset(resp.TimeZoneOffset)
 	d.SetDaylightSavingTimeEnabled(resp.DaylightSavingTimeEnabled)
-	d.SetLocalProcessingAgentId(resp.HybridDeploymentAgentId)
 	d.SetHybridDeploymentAgentId(resp.HybridDeploymentAgentId)
 	d.SetNetworkingMethod(resp.NetworkingMethod)
 	d.SetPrivateLinkId(resp.PrivateLinkId)

fivetran/framework/core/model/destination_datasource_model.go

@@ -15,7 +15,6 @@ type DestinationDatasourceModel struct {
 	TimeZoneOffset				 types.String `tfsdk:"time_zone_offset"`
 	SetupStatus    				 types.String `tfsdk:"setup_status"`
 	DaylightSavingTimeEnabled	 types.Bool   `tfsdk:"daylight_saving_time_enabled"`
-    LocalProcessingAgentId       types.String `tfsdk:"local_processing_agent_id"`
     HybridDeploymentAgentId      types.String `tfsdk:"hybrid_deployment_agent_id"`
     NetworkingMethod             types.String `tfsdk:"networking_method"`
     PrivateLinkId                types.String `tfsdk:"private_link_id"`
@@ -52,13 +51,6 @@ func (d *DestinationDatasourceModel) SetPrivateLinkId(value string) {
         d.PrivateLinkId = types.StringNull()
     }
 }
-func (d *DestinationDatasourceModel) SetLocalProcessingAgentId(value string) {
-    if value != "" {
-        d.LocalProcessingAgentId = types.StringValue(value)
-    } else {
-        d.LocalProcessingAgentId = types.StringNull()
-    }
-}
 func (d *DestinationDatasourceModel) SetHybridDeploymentAgentId(value string) {
     if value != "" {
         d.HybridDeploymentAgentId = types.StringValue(value)

fivetran/framework/core/model/destination_resource_model.go

@@ -18,7 +18,6 @@ type DestinationResourceModel struct {
 	DaylightSavingTimeEnabled	 types.Bool   	`tfsdk:"daylight_saving_time_enabled"`
 	Config  					 types.Object   `tfsdk:"config"`
 	Timeouts					 timeouts.Value `tfsdk:"timeouts"`
-    LocalProcessingAgentId       types.String   `tfsdk:"local_processing_agent_id"`
     HybridDeploymentAgentId      types.String   `tfsdk:"hybrid_deployment_agent_id"`
     NetworkingMethod             types.String   `tfsdk:"networking_method"`
     PrivateLinkId                types.String `tfsdk:"private_link_id"`
@@ -51,13 +50,6 @@ func (d *DestinationResourceModel) SetSetupStatus(value string) {
 func (d *DestinationResourceModel) SetDaylightSavingTimeEnabled(value bool) {
 	d.DaylightSavingTimeEnabled = types.BoolValue(value)
 }
-func (d *DestinationResourceModel) SetLocalProcessingAgentId(value string) {
-    if value != "" && !d.LocalProcessingAgentId.IsUnknown() && !d.LocalProcessingAgentId.IsNull() {
-        d.LocalProcessingAgentId = types.StringValue(value)
-    } else {
-        d.LocalProcessingAgentId = types.StringNull()
-    }
-}
 func (d *DestinationResourceModel) SetHybridDeploymentAgentId(value string) {
     if value != "" {
         d.HybridDeploymentAgentId = types.StringValue(value)

fivetran/framework/core/model/destinations.go

@@ -22,7 +22,6 @@ func (d *Destinations) ReadFromResponse(ctx context.Context, resp destinations.D
         "time_zone_offset":             types.StringType,
         "setup_status":                 types.StringType,
         "networking_method":            types.StringType,
-        "local_processing_agent_id":    types.StringType,
         "hybrid_deployment_agent_id":   types.StringType,
         "private_link_id":              types.StringType,
         "daylight_saving_time_enabled": types.BoolType,
@@ -43,7 +42,6 @@ func (d *Destinations) ReadFromResponse(ctx context.Context, resp destinations.D
         item["time_zone_offset"] = types.StringValue(v.TimeZoneOffset)
         item["setup_status"] = types.StringValue(v.SetupStatus)
         item["private_link_id"] = types.StringValue(v.PrivateLinkId)
-        item["local_processing_agent_id"] = types.StringValue(v.HybridDeploymentAgentId)
         item["hybrid_deployment_agent_id"] = types.StringValue(v.HybridDeploymentAgentId)
         item["networking_method"] = types.StringValue(v.NetworkingMethod)
         item["daylight_saving_time_enabled"] = types.BoolValue(v.DaylightSavingTimeEnabled)