Created a new example for OAuth2 with Token Refresh #74
+257
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to and will mark 1 task as "Done" when merged:
|
fivetran-pranavtotala
requested review from
varundhall,
rajat-kushwaha and
fivetran-rishabhghosh
varundhall
requested changes
Jan 30, 2025
examples/source_examples/oauth2_with_token_refresh/connector.py
Outdated
Show resolved
Hide resolved
examples/source_examples/oauth2_with_token_refresh/connector.py
Outdated
Show resolved
Hide resolved
examples/source_examples/oauth2_with_token_refresh/connector.py
Outdated
Show resolved
Hide resolved
examples/source_examples/oauth2_with_token_refresh/connector.py
Outdated
Show resolved
Hide resolved
examples/source_examples/oauth2_with_token_refresh/connector.py
Outdated
Show resolved
Hide resolved
varundhall
requested changes
Jan 31, 2025
examples/source_examples/oauth2_with_token_refresh/Screenshot1.png
Outdated
Show resolved
Hide resolved
examples/source_examples/oauth2_with_token_refresh/connector.py
Outdated
Show resolved
Hide resolved
Comment on lines
40
to
43
| uri = AUTH_URL + urllib.parse.urlencode(param_dict) | ||
| headers = {'content-type': 'application/x-www-form-urlencoded'} | ||
|
|
||
| response = requests.request("POST", uri, headers=headers) |
There was a problem hiding this comment.
let use response = requests.post(AUTH_URL, headers=headers, data=param_dict) or similar, to make code more readable
There was a problem hiding this comment.
passing it in params is not working as it is not encoding the url as required. changing it to request.post
examples/source_examples/oauth2_with_token_refresh/connector.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes T-863159
Tested with fivetran debug and deploy
Added a readme file