[Bug Fix] Zendesk hyperlink additions #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
requested changes
Nov 7, 2024
There was a problem hiding this comment.
@fivetran-avinash these changes look great to me! I have just a few notes for you to address before approval.
CHANGELOG.md
Outdated
| # dbt_unified_rag v0.1.0-a3 | ||
| [PR #9](https://github.com/fivetran/dbt_unified_rag/pull/9) includes the following updates: | ||
|
|
||
| ## Bug Fix |
There was a problem hiding this comment.
Since this is going to be updating the underlying data flowing into the incremental model, we should callout that a full refresh is required when making this upgrade.
fivetran-avinash
commented
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: [#8]
This PR will result in the following new package version: v0.1.0-a3
Fixed Zendesk URLs so it produced hyperlinks. Didn't really change any fields though.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fix
urllogic instg_rag_zendesk__ticketto provide the proper clickable URL to Zendesk tickets. This way, theurl_referencein therag__unified_documentproperly generates a hyperlink for Zendesk documents.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Checked to see if the Zendesk hyperlinks properly generated the specified format, based on Help Center docs.
If you had to summarize this PR in an emoji, which would it be?
🔗