Addressing the FR raised against the package to add the title field t… #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-jamie
requested changes
Jan 10, 2025
There was a problem hiding this comment.
This looks really good! Largely left Hubspot suggestions/comments around using different sorts of titles.
FYI I pushed a commit to your branch fixing an unrelated issue around the rag__using_<zendesk/jira/hubspot> variables, so you'll need to git fetch && git pull origin feature/add-title-to-rag__unified_document before making any new changes
Thank you so much for helping us out here @fivetran-poonamagate !
models/intermediate/hubspot/int_rag_hubspot__deal_comment_document.sql
Outdated
Show resolved
Hide resolved
models/intermediate/hubspot/int_rag_hubspot__deal_comment_document.sql
Outdated
Show resolved
Hide resolved
models/intermediate/hubspot/int_rag_hubspot__deal_comment_document.sql
Outdated
Show resolved
Hide resolved
models/intermediate/hubspot/int_rag_hubspot__deal_comment_document.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This looks awesome @fivetran-poonamagate! Couple of super tiny suggestions. If you have time to address them, that'd be great, but the PR is already in a great spot for our team to take over for polishes and such if not
models/intermediate/hubspot/int_rag_hubspot__deal_comment_document.sql
Outdated
Show resolved
Hide resolved
models/intermediate/hubspot/int_rag_hubspot__deal_comment_document.sql
Outdated
Show resolved
Hide resolved
fivetran-jamie
approved these changes
Jan 17, 2025
fivetran-joemarkiewicz
requested changes
Jan 21, 2025
Co-authored-by: Joe Markiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o relevant models
Please provide your name and company
Poonam Agate
Link the issue/feature request which this PR is meant to address
#15
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
Adds the title field to the rag__unified_document model
How did you validate the changes introduced within this PR?
Ran the proposed package updates in BigQuery and confirmed that the models ran successfully
Which warehouse did you use to develop these changes?
BigQuery
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Typically there are additional maintenance changes required before this will be ready for an upcoming release. Are you comfortable with the Fivetran team making a few commits directly to your branch?
If you had to summarize this PR in an emoji, which would it be?
🐝
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)