-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/remove-age #22
Changes from 3 commits
53d0b21
12945b1
5fcef85
cbf42af
1df1fbf
2ac463e
daa6c4a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# DECISION LOG | ||
|
||
## Why don't metrics add up across different grains (Ex. ad level vs campaign level)? | ||
Not all ads are served at the ad level. In other words, there are some ads that are served only at the ad group, campaign, etc. levels. The implications are that since not ads are included in the ad-level report, their associated spend, for example, won't be included at that grain. Therefore your spend totals may differ across the ad grain and another grain. | ||
|
||
This is a reason why we have broken out the ad reporting packages into separate hierarchical end models (Ad, Ad Group, Campaign, and more). Because if we only used ad-level reports, we could be missing data. | ||
|
||
## `age_groups` and `age` columns | ||
In the [July 2023 TikTok Ads connector update](https://fivetran.com/docs/connectors/applications/tiktok-ads/changelog#july2023), we renamed the `age` column in the `ADGROUP_HISTORY` table to `age_groups`. To maintain compatibility with connectors using the old column name, our data models previously coalesced the `age` and `age_groups` columns. However, due to inconsistent data types between `age` and `age_groups`, this approach began causing errors. | ||
|
||
### Decision | ||
- The `age` column has been removed from the `stg_tiktok_ads__ad_group_history` model and the `fill` staging macro for the ad group history table. | ||
- Models now rely exclusively on the `age_groups` column. | ||
|
||
### Impact | ||
- Customers using the `age` column will no longer have access to this field in the models. | ||
- The change simplifies logic and resolves data inconsistency issues caused by merging fields with different data types. | ||
|
||
### Action for Customers Requiring Historical `age` Data | ||
Customers who still need the historical `age` column data can: | ||
1. Resync the `ADGROUP_HISTORY` table in their TikTok Ads connector. TikTok provides all historical data in the `age_groups` column, allowing the data to be fully populated. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as source -- if there's no second option, we should remove the |
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
packages: | ||
- package: fivetran/tiktok_ads_source | ||
version: [">=0.6.0", "<0.7.0"] | ||
# - package: fivetran/tiktok_ads_source | ||
# version: [">=0.7.0", "<0.8.0"] | ||
- git: https://github.com/fivetran/dbt_tiktok_ads_source.git | ||
revision: feature/remove-age | ||
warn-unpinned: false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reminder to swap before release.
fivetran-catfritz marked this conversation as resolved.
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should callout that these are upstream breaking changes. Since the
age_groups
column isn't used in any models within dbt_tiktok_ads it could be confusing to read this and wonder where the age_groups column was before. We should clearly callout that this change really only impacts the upstream staging model.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!